Skip to content

bpo-45150: Add hashlib.file_digest() for efficient file hashing - #31930

Merged
miss-islington merged 6 commits into
python:mainfrom
tiran:bpo-45150-file-digest
Mar 22, 2022
Merged

bpo-45150: Add hashlib.file_digest() for efficient file hashing#31930
miss-islington merged 6 commits into
python:mainfrom
tiran:bpo-45150-file-digest

Conversation

@tiran

@tirantiran commented Mar 16, 2022•
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45150

Automerge-Triggered-By: GH:tiran

@tiran
tiranforce-pushed the bpo-45150-file-digest branch from 1d6869b to 9b218daCompareMarch 16, 2022 12:33
@tiran
tiranforce-pushed the bpo-45150-file-digest branch from 9b218da to 71f0401CompareMarch 16, 2022 12:38
@tiran
tiran requested a review from gpsheadMarch 16, 2022 14:37
gpshead
gpshead requested changes Mar 16, 2022
View reviewed changes

@gpsheadgpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you implemented this in pure Python.

Comment threadLib/hashlib.py Outdated
Comment threadLib/hashlib.py Outdated
Comment threadLib/test/test_hashlib.py
Comment threadDoc/library/hashlib.rst Outdated
@bedevere-bot

bedevere-bot commented Mar 16, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpsheadgpshead mentioned this pull request Mar 16, 2022
Closed
@tiran
tiran requested a review from gpsheadMarch 17, 2022 11:08
gpshead
gpshead reviewed Mar 17, 2022
View reviewed changes
Comment threadLib/test/test_hashlib.py Outdated
@gpsheadgpshead added the type-feature A feature request or enhancement label Mar 21, 2022
gpshead
gpshead reviewed Mar 21, 2022
View reviewed changes
Comment threadLib/test/test_hashlib.py Outdated
@tiran
tiran requested a review from gpsheadMarch 22, 2022 07:45
@miss-islington
miss-islington merged commit 4f97d64 into python:mainMar 22, 2022
@markshannon

markshannon commented Mar 22, 2022

Copy link
Copy Markdown
Member

This may have broken the buildbots.
https://buildbot.python.org/all/#/builders/713/builds/452

@tiran

tiran commented Mar 22, 2022

Copy link
Copy Markdown
MemberAuthor

This may have broken the buildbots. buildbot.python.org/all/#/builders/713/builds/452

FIPS ... let's see if GH-32046 solves the issue.

@tiran
tiran deleted the bpo-45150-file-digest branch March 22, 2022 13:24
@tirantiran mentioned this pull request Apr 21, 2022
Closed
@tarekziadetarekziademannequin mentioned this pull request Aug 13, 2022
Closed
musashay23

This comment was marked as spam.

Sign in to view

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes
+1 more reviewer
@musashay23musashay23musashay23 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tiran@bedevere-bot@markshannon@gpshead@musashay23@the-knights-who-say-ni@miss-islington