Uh oh!
There was an error while loading. Please reload this page.
bpo-29576: Improve some deprecations in the importlib - #32
Conversation
There was a problem hiding this comment.
typo here s/MetaPatFinder/MetaPathFinder/
Codecov Report
@@ Coverage Diff @@## master #32 +/- ##
==========================================
- Coverage 82.37% 82.36% -0.01%
==========================================
Files 1427 1427 Lines 350948 350951 +3 ==========================================
- Hits 289093 289062 -31 - Misses 61855 61889 +34Continue to review full report at Codecov.
|
brettcannon
left a comment
There was a problem hiding this comment.
Could you add tests to make sure the warnings are being raised?
There was a problem hiding this comment.
This line is somewhat redundant since the deprecation is mentioned in the previous paragraph. Maybe just add the version it was deprecated in above?
There was a problem hiding this comment.
The deprecation is mentioned in the above paragraph, so if you would like to add the version info just toss in up there.
Add the python version since the functionality is deprecated, and raise a couple of deprecation warnings in a few places. Theses functions are marked as deprecated in the documentation, but especially in existing codebase, programmers tends to not re-check whether functions are deprecated. So trigger the warning when possible. It's also more probable that a developer will drop deprecated functionality if we immediately give them information about replacement API, and not have them to go find it in the documentation. Include deprecation information in DocString as well as many tools pull documentation from there and not from docs.python.org. Add test making sure `find_loader()` and `find_module()` Both emit a deprecation warning.
Carreau
commented
Feb 15, 2017
All comments should be addressed. |
brettcannon
commented
Feb 15, 2017
Thanks! Please add entries in Misc/NEWS and one in What's New in the "deprecated" section and this will be ready to be merged! |
brettcannon
commented
Feb 16, 2017
Thanks! |
Carreau
commented
Feb 16, 2017
Thanks ! |
Add the python version since the functionality is deprecated,
and raise a couple of deprecation warnings in a few places.
Theses functions are marked as deprecated in the documentation, but
especially in existing codebase, programmers tends to not re-check
whether functions are deprecated. So trigger the warning when possible.
It's also more probable that a developer will drop deprecated
functionality if we immediately give them information about
replacement API, and not have them to go find it in the documentation.
Include deprecation information in DocString as well, as many tools pull
documentation from there and not from docs.python.org.