Skip to content

bpo-43166: Disable ceval.c optimizations for Windows debug builds again - #32023

Merged
zooba merged 10 commits into
python:mainfrom
neonene:bpo-43166
Mar 23, 2022
Merged

bpo-43166: Disable ceval.c optimizations for Windows debug builds again#32023
zooba merged 10 commits into
python:mainfrom
neonene:bpo-43166

Conversation

@neonene

@neoneneneonene commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

Debug builds' optimization could be reconsidered as 3.11a6+ has reduced the stack usage. Disabling on MSVC should fix the build performance regression and make ceval.c debuggable.

test_xml_etree, which is the top stack consumer among 17 tests mentioned in bpo-43271, requires the following bytes:

Optimizationx64x86
Enabled (/Og /Ot)1,100,000500,000
Disabled3,900,0002,300,000

They include 200,000 bytes usage with /Ob1 (OnlyExplicitInline) option introduced by #10094 for running performance.

https://bugs.python.org/issue43166

@neonene

Copy link
Copy Markdown
ContributorAuthor

Small improvement on GitHub test machines.

Build timex64x86
before (e63894b)3:15.283:10.90
This(1ebe5f4 )2:54.562:29.58

Comment threadInclude/pyport.h Outdated
Comment threadPCbuild/_freeze_module.vcxproj Outdated
@zooba
zooba merged commit cd05d0a into python:mainMar 23, 2022
@neonene

Copy link
Copy Markdown
ContributorAuthor

Thanks!

@neonene
neonene deleted the bpo-43166 branch March 23, 2022 01:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@neonene@zooba@the-knights-who-say-ni@bedevere-bot