Skip to content

[backport to 3.6] bpo-28929: Link the documentation to its source file on GitHub - #37

Merged
Mariatta merged 2 commits into
python:3.6from
Mariatta:issue-28928-3.6
Feb 12, 2017
Merged

[backport to 3.6] bpo-28929: Link the documentation to its source file on GitHub#37
Mariatta merged 2 commits into
python:3.6from
Mariatta:issue-28928-3.6

Conversation

@Mariatta

Copy link
Copy Markdown
Member

Change the documentation's Show Source link on the left menu
to GitHub source file.

(cherry picked from commit 23bafa2)

Change the documentation's `Show Source` link on the left menu
to GitHub source file.
(cherry picked from commit 23bafa2)
@MariattaMariatta added the type-feature A feature request or enhancement label Feb 12, 2017
<li><a href="{{ pathto('_sources/' + sourcename, true)|e }}"
rel="nofollow">{{ _('Show Source') }}</a></li>
<li>
{% if version == "3.7" %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this updated when Python 3.7 is released?
I think 2.7, 3.5, and 3.6 branch should not have this if statement.
Or could we pass variable like doc_source_url_prefix = "https://github.com/python/cpython/blob/3.6/Doc/" from conf?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @methane :)
I removed the if statement as suggested.
Branches 2.7, 3.5, and 3.6 don't have the if statement anymore.

@Mariatta
Mariatta merged commit f66c81f into python:3.6Feb 12, 2017
@Mariatta
Mariatta deleted the issue-28928-3.6 branch February 12, 2017 21:08
kumaraditya303 pushed a commit to kumaraditya303/cpython that referenced this pull request Aug 22, 2022
jaraco pushed a commit that referenced this pull request Dec 2, 2022
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Support for is_resource() and contents()
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
* Replace pep517.build with build
Resolvespython#30
* Prefer simple usage
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
* Use `extend-ignore` in flake8 config
This option allows to add extra ignored rules to the default list
instead of replacing it.
The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.
Fixespython#28.
Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore
* Enable complexity limit. Fixesjaraco/skeleton#34.
* Replace pep517.build with build (python#37)
* Replace pep517.build with build
Resolvespython#30
* Prefer simple usage
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
* Use license_files instead of license_file in meta (python#35)
Singular `license_file` is deprecated since wheel v0.32.0.
Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Fidget-Spinner referenced this pull request in pylbbv/pylbbv May 27, 2023
* Tests: Modified dis.py and added primitive tests
* Docs: Typos and more documentation
* Test: Fixed minor issue
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-featureA feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Mariatta@berkerpeksag@methane@the-knights-who-say-ni