Skip to content

bpo-32787: Better error handling in ctypes. - #3727

Merged
serhiy-storchaka merged 11 commits into
python:masterfrom
serhiy-storchaka:ctypes-no-hasattr
Dec 5, 2018
Merged

bpo-32787: Better error handling in ctypes.#3727
serhiy-storchaka merged 11 commits into
python:masterfrom
serhiy-storchaka:ctypes-no-hasattr

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Sep 24, 2017

Copy link
Copy Markdown
Member

}

len = PySequence_Length(fields);
len = PySequence_Size(fields);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why LengthSize?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PySequence_Size is more commonly used. PySequence_Length is just an outdated alias of PySequence_Size.

@serhiy-storchakaserhiy-storchaka changed the title bpo-31572: Get rid of PyObject_HasAttrString() in ctypes.bpo-32787: Better error handling in ctypes.Feb 7, 2018
@serhiy-storchaka
serhiy-storchaka merged commit 398bd27 into python:masterDec 5, 2018
@bedevere-bot

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@bedevere-bot@eric-wieser@the-knights-who-say-ni