Uh oh!
There was an error while loading. Please reload this page.
bpo-29711: Fix stop_serving in proactor loop kill all listening servers - #431
Merged
Merged
Conversation
mention-bot
commented
Mar 3, 2017
1st1
commented
Mar 3, 2017
Member
@Haypo Can you take a look at this PR? |
julien-duponchelle
commented
Aug 21, 2017
ContributorAuthor
Can I do something to help ? |
vstinner
commented
Aug 21, 2017
Member
I agree that it's plain wrong to cancel the "accept future" of all listening servers. |
1st1
commented
Oct 19, 2017
Member
Could you please add a NEWS entry using blurb? |
1st1
approved these changes
Oct 19, 2017
asvetlov
commented
Dec 13, 2017
Contributor
@noplay ping |
julien-duponchelleforce-pushed
the
fix-issue-29711
branch
from
December 13, 2017 21:11
ca0f031 to
42a07c5Comparejulien-duponchelle
commented
Dec 13, 2017
ContributorAuthor
News entry added |
1st1
commented
Dec 18, 2017
Member
Could you please rebase your PR once again? |
julien-duponchelleforce-pushed
the
fix-issue-29711
branch
from
December 18, 2017 20:19
42a07c5 to
8f11cb3Comparejulien-duponchelle
commented
Dec 18, 2017
ContributorAuthor
It's rebase |
1st1
approved these changes
Dec 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.
Original discussion: python/asyncio#496
https://bugs.python.org/issue29711