Skip to content

bpo-30579: Docs for dynamic traceback creation - #5653

Merged
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:whats-new-mutable-tracebacks
Feb 13, 2018
Merged

bpo-30579: Docs for dynamic traceback creation#5653
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:whats-new-mutable-tracebacks

Conversation

@ncoghlan

@ncoghlanncoghlan commented Feb 13, 2018•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@ncoghlan

ncoghlan commented Feb 13, 2018

Copy link
Copy Markdown
ContributorAuthor

I merged this without doc updates prior to beta 1, so this backfills the missing details.

The handling of frame and traceback objects in the language reference could stand to be significantly improved in general, but this is a deliberately minimal update in order to cover the changes that were made.

@ncoghlan
ncoghlan merged commit aec7532 into python:masterFeb 13, 2018
@miss-islington

miss-islington commented Feb 13, 2018

Copy link
Copy Markdown
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2018
@ncoghlan@miss-islington
bpo-30579: Docs for dynamic traceback creation (pythonGH-5653)
7e1b6fb
(cherry picked from commit aec7532)
Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 13, 2018

Copy link
Copy Markdown

GH-5655 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 13, 2018
@miss-islington@ncoghlan
bpo-30579: Docs for dynamic traceback creation (GH-5653)
53374cc
(cherry picked from commit aec7532)
Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
@ncoghlan
ncoghlan deleted the whats-new-mutable-tracebacks branch March 30, 2018 07:53
merwok
merwok reviewed Dec 29, 2018
View reviewed changes
Comment threadDoc/library/types.rst


.. data:: TracebackType
.. class:: TracebackType(tb_next, tb_frame, tb_lasti, tb_lineno)

@merwokmerwokDec 29, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In class directives, things in parens should be base classes, not constructor parameters.

@ncoghlanncoghlanDec 31, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merwok This PR is old enough now that fixing the markup here is likely better handled as a separate issue on the tracker.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments
@njsmithnjsmithnjsmith approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ncoghlan@miss-islington@bedevere-bot@njsmith@merwok@the-knights-who-say-ni