Uh oh!
There was an error while loading. Please reload this page.
[3.7] bpo-32873: Treat type variables and special typing forms as immutable by copy and pickle (GH-6216) - #6264
Merged
Conversation
… by copy and pickle (pythonGH-6216) This also fixespython/typingGH-512 This also fixespython/typingGH-511 As was discussed in both issues, some typing forms deserve to be treated as immutable by copy and pickle modules, so that: * copy(X) is X * deepcopy(X) is X * loads(dumps(X)) is X GH- pickled by reference This PR adds such behaviour to: * Type variables * Special forms like Union, Any, ClassVar * Unsubscripted generic aliases to containers like List, Mapping, Iterable This not only resolves inconsistencies mentioned in the issues, but also improves backwards compatibility with previous versions of Python (including 3.6). Note that this requires some dances with __module__ for type variables (similar to NamedTuple) because the class TypeVar itself is define in typing, while type variables should get module where they were defined. https://bugs.python.org/issue32873 (cherry picked from commit 8349403) Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
ilevkivskyi
approved these changes
Mar 26, 2018
gvanrossum
approved these changes
Mar 26, 2018
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Yes, backport to 3.7 is the intended target! (But no further.)
miss-islington
commented
Mar 26, 2018
ContributorAuthor
@ilevkivskyi: Backport status check is done, and it's a success ✅ . |
miss-islington
commented
Mar 26, 2018
ContributorAuthor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixespython/typingGH-512
This also fixespython/typingGH-511
As was discussed in both issues, some typing forms deserve to be treated
as immutable by copy and pickle modules, so that:
This PR adds such behaviour to:
This not only resolves inconsistencies mentioned in the issues, but also
improves backwards compatibility with previous versions of Python
(including 3.6).
Note that this requires some dances with module for type variables
(similar to NamedTuple) because the class TypeVar itself is define in typing,
while type variables should get module where they were defined.
https://bugs.python.org/issue32873
(cherry picked from commit 8349403)
Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com
https://bugs.python.org/issue32873