Uh oh!
There was an error while loading. Please reload this page.
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() - #7130
Merged
Conversation
asvetlov
commented
May 26, 2018
Contributor
hmm, windows tests are failing |
1st1
commented
May 26, 2018
MemberAuthor
Yes, i'll be looking into win issues before merging. |
1st1
commented
May 27, 2018
MemberAuthor
@asvetlov please take a look at the 0238da4 -- I think I fixed the windows issue |
asvetlov
commented
May 28, 2018
Contributor
Wow, nice. |
miss-islington
commented
May 28, 2018
Contributor
Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2018
…pythonGH-7130) In this commit: * Support BufferedProtocol in set_protocol() and start_tls() * Fix proactor to cancel readers reliably * Update tests to be compatible with OpenSSL 1.1.1 * Clarify BufferedProtocol docs * Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving * Rewrite test_start_tls_server_1 (cherry picked from commit dbf1022) Co-authored-by: Yury Selivanov <yury@magic.io>
bedevere-bot
commented
May 28, 2018
GH-7164 is a backport of this pull request to the 3.7 branch. |
miss-islington added a commit
that referenced
this pull request
May 28, 2018
…GH-7130) In this commit: * Support BufferedProtocol in set_protocol() and start_tls() * Fix proactor to cancel readers reliably * Update tests to be compatible with OpenSSL 1.1.1 * Clarify BufferedProtocol docs * Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving * Rewrite test_start_tls_server_1 (cherry picked from commit dbf1022) Co-authored-by: Yury Selivanov <yury@magic.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33654