Uh oh!
There was an error while loading. Please reload this page.
[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208) - #7215
Conversation
Original patch by Dan O'Reilly. (cherry picked from commit 5d97b7b) Co-authored-by: Yury Selivanov <yury@magic.io>
bedevere-bot
commented
May 29, 2018
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
vstinner
commented
May 29, 2018
https://bugs.python.org/issue22087 is as old as asyncio and people learnt how to work around the issue. I don't think that there is any kind of urgency to merge this change into 3.7. I would prefer to leave 3.7 unchanged, and test the change in 3.8 instead. It's too late for 3.7, we are very close to the 3.7rc1. |
1st1
commented
May 29, 2018
I don't see why it's too late.
This doesn't sound as an actual explanation why this shouldn't be merged. I don't see any technical problem with this patch or how it can possibly break anything. |
miss-islington
commented
May 29, 2018
@1st1: Backport status check is done, and it's a success ✅ . |
miss-islington
commented
May 29, 2018
Thanks! |
Original patch by Dan O'Reilly.
(cherry picked from commit 5d97b7b)
Co-authored-by: Yury Selivanov yury@magic.io
https://bugs.python.org/issue22087