Skip to content

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown - #8096

Merged
encukou merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-20602-sys-flags-sys-float_info-clear
May 30, 2019
Merged

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown#8096
encukou merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-20602-sys-flags-sys-float_info-clear

Conversation

@ZackerySpytz

@ZackerySpytzZackerySpytz commented Jul 4, 2018•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

There is no need to clear these immutable objects during shutdown.

https://bugs.python.org/issue20602

@ZackerySpytz
ZackerySpytz requested a review from a teamJuly 4, 2018 22:59
@serhiy-storchaka
serhiy-storchaka requested review from tiran and removed request for a teamJuly 5, 2018 12:38
serhiy-storchaka
serhiy-storchaka previously requested changes Oct 12, 2018
View reviewed changes
Comment threadLib/test/test_sys.py
@bedevere-bot

bedevere-bot commented Oct 12, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz

ZackerySpytz commented Nov 15, 2018

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Nov 15, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

tiran
tiran approved these changes May 29, 2019
View reviewed changes

@tirantiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The PR has been dormant for a while. Do you want to land it in 3.8?

@ZackerySpytz

ZackerySpytz commented May 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, @tiran.

For what it's worth, I would like to see this land in 3.8.

@tiran

tiran commented May 29, 2019

Copy link
Copy Markdown
Member

@ZackerySpytz Could you please rebase the PR to kick off another test run?

@ZackerySpytz
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown
932feb6
There is no need to clear these immutable objects during shutdown.
@ZackerySpytz
ZackerySpytzforce-pushed the bpo-20602-sys-flags-sys-float_info-clear branch from dd4b698 to 932feb6CompareMay 29, 2019 21:20
tiran
tiran approved these changes May 30, 2019
View reviewed changes

@tirantiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou
encukou merged commit 249b7d5 into python:masterMay 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz@DinoV
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (p…
6e0a3e7
…ythonGH-8096)
There is no need to clear these immutable objects during shutdown.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirantirantiran approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments
@brettcannonbrettcannonAwaiting requested review from brettcannon
@encukouencukouAwaiting requested review from encukou
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently
@ncoghlanncoghlanAwaiting requested review from ncoghlan
@warsawwarsawAwaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz@bedevere-bot@tiran@serhiy-storchaka@encukou@the-knights-who-say-ni