Uh oh!
There was an error while loading. Please reload this page.
bpo-33723: Remove time.thread_time() functional tests - #8265
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
These functional tests were too fragile: we already tolerate to only get a delta of 20 ms whereas the test runs a busy loop during 100 ms. The test failed on a buildbot because the delta was only 19 ms. Reducing the minimum delta would make the test meaningless, so remove it instead.
pitrou
commented
Jul 12, 2018
Member
Pity :-( Perhaps we should have a requirement that buildbots do not get deployed on overloaded machines? This kind of test is useful. |
vstinner
commented
Jul 12, 2018
MemberAuthor
vstinner
commented
Jul 12, 2018
MemberAuthor
I merged the PR 8267. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functional tests were too fragile: we already tolerate to only
get a delta of 20 ms whereas the test runs a busy loop during 100 ms.
The test failed on a buildbot because the delta was only 19 ms.
Reducing the minimum delta would make the test meaningless, so remove
it instead.
https://bugs.python.org/issue33723