bpo-20774: Add a JSON serializer to collections.deque by lisroach · Pull Request #830 · python/cpython

lisroach · 2017-03-27T01:40:40Z

PR for issue 20774, adding a JSON serializer to collections.deque.

https://bugs.python.org/issue20774

mention-bot · 2017-03-27T01:40:41Z

@lisroach, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @benjaminp and @loewis to be potential reviewers.

rhettinger

Over this looks good. Can you please add some tests.

Birne94 · 2017-03-27T09:43:37Z

 /* Encode Python object obj to a JSON term */
 PyObject *newobj;
 int rv;
+ PyObject *mo = PyImport_ImportModule("collections");


Wouldn't you need to decrease the reference counter to mo and deque_type after using them?

brettcannon · 2018-02-21T01:51:38Z

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

sakurai-youhei · 2019-01-14T03:55:05Z

For those who arrived here like me when searching quick solution to encode dqeue object into JSON; Below code (as per documentation) shall be good enough.

from collections import deque
from json import dumps, JSONEncoder
class JSONEncoderSupportingArbitraryIterators(JSONEncoder):
def default(self, o):
try:
iterable = iter(o)
except TypeError:
pass
else:
return list(iterable)
# Let the base class default method raise the TypeError
return JSONEncoder.default(self, o)
dumps(deque(range(10)), cls=JSONEncoderSupportingArbitraryIterators)

carlbordum · 2019-03-04T20:45:51Z

@lisroach are you interested in writting the tests, or may I? :)

lisroach · 2019-03-06T05:18:29Z

Sorry, just realized I had this sitting for so long! @carlbordum feel free to add more tests if you think of them :)

matrixise · 2019-03-06T05:23:32Z


 from test.support import bigmemtest, _1G

+


Maybe you could remove this blank line

matrixise · 2019-03-06T05:23:52Z

@@ -47,7 +48,6 @@ def __lt__(self, o):
 d[1337] = "true.dat"
 self.assertEqual(self.dumps(d, sort_keys=True), '{"1337": "true.dat"}')



Why this line ?

csabella · 2019-06-05T01:09:48Z

@lisroach, should this pull request be closed based on the performance benchmarks mentioned on the bug tracker or were you still working on this change? Thanks!

github-actions · 2022-02-19T00:08:23Z

This PR is stale because it has been open for 30 days with no activity.

erlend-aasland · 2022-06-29T19:14:10Z

@lisroach, are you going to follow up this PR?

kumaraditya303 · 2022-07-09T15:03:46Z

Closing because of lack of response and conflicts, feel free to reopen if you want to work on this.

lisroach added 12 commits February 20, 2017 11:41

Updates B.index documentation.
982257f

Updates str.index documentation, makes it Argument Clinic compatible.
5860a7f

Removes ArgumentClinic code.
25e2482

Finishes string.index documentation.
edae59d

Updates string.rindex documentation.
5e182a6

Documents B.rindex.
1e950a2

Merge remote-tracking branch 'upstream/master'
8c39ad3

Updates python iterencode for deques.
c464923

Adds check for deque along with list and tuple.
82de7ac

Adds IsInstance instead of PyTYPE conversion.
7087e1a

Reverting old documentation update.
30d6ec5

Fixes weird missing newline at end of file.
6161979

the-knights-who-say-ni added the CLA signed label Mar 27, 2017

Mariatta changed the title ~~Issue20774~~bpo-20774: Add a JSON serializer to collections.dequeMar 27, 2017

rhettinger requested changes Mar 27, 2017
View reviewed changes

Birne94 reviewed Mar 27, 2017
View reviewed changes

brettcannon added the type-feature A feature request or enhancement label Mar 28, 2017

brettcannon added the awaiting changes label Feb 21, 2018

Adds unit tests, docs, fixes ref leak.
697f1bf

matrixise reviewed Mar 6, 2019
View reviewed changes

Removes blank line.
5126064

csabella assigned lisroach Jan 25, 2020

github-actionsBot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022

acdhamannequin mentioned this pull request Apr 10, 2022
collections.deque should ship with a stdlib json serializer #64973
Open

erlend-aasland added the pending The issue will be closed if no feedback is provided label Jun 29, 2022

github-actionsBot removed the stale Stale PR or inactive for long period of time. label Jun 30, 2022

kumaraditya303 closed this Jul 9, 2022

AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025

		@@ -47,7 +48,6 @@ def __lt__(self, o):
		d[1337] = "true.dat"
		self.assertEqual(self.dumps(d, sort_keys=True), '{"1337": "true.dat"}')

Uh oh!

Uh oh!

Conversation

lisroach commented Mar 27, 2017• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Mar 27, 2017

Uh oh!

rhettinger left a comment

Choose a reason for hiding this comment

Uh oh!

Birne94Mar 27, 2017

Choose a reason for hiding this comment

Uh oh!

brettcannon commented Feb 21, 2018

Uh oh!

sakurai-youhei commented Jan 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlbordum commented Mar 4, 2019

Uh oh!

lisroach commented Mar 6, 2019

Uh oh!

matrixiseMar 6, 2019

Choose a reason for hiding this comment

Uh oh!

matrixiseMar 6, 2019

Choose a reason for hiding this comment

Uh oh!

csabella commented Jun 5, 2019

Uh oh!

github-actionsBot commented Feb 19, 2022

Uh oh!

erlend-aasland commented Jun 29, 2022

Uh oh!

kumaraditya303 commented Jul 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

lisroach commented Mar 27, 2017•
edited by bedevere-bot
Loading

sakurai-youhei commented Jan 14, 2019•
edited
Loading