Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.2k
bpo-33073: Adding as_integer_ratio to ints.#8750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
ff0790ed1daadc3b89b6f48c7dd04ca566a2336cb4673a0ca5102589a935a7b3cd076c028417a2028d9789a0d9d148225cac0f11fcb9c978d311b83d3ef843File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Added as_integer_ratio to ints to make them more interoperable with floats. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5260,6 +5260,36 @@ long_is_finite(PyObject *v) | ||
| } | ||
| #endif | ||
| /*[clinic input] | ||
| int.as_integer_ratio | ||
| Return integer ratio. | ||
| Return a pair of integers, whose ratio is exactly equal to the original int | ||
| and with a positive denominator. | ||
| >>> (10).as_integer_ratio() | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need so much examples in a docstring? Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's useful to have at least one positive and one negative example, so that it's obvious at a glance that the behaviour for negatives is to give (for example) | ||
| (10, 1) | ||
| >>> (-10).as_integer_ratio() | ||
| (-10, 1) | ||
| >>> (0).as_integer_ratio() | ||
| (0, 1) | ||
| [clinic start generated code]*/ | ||
| static PyObject * | ||
| int_as_integer_ratio_impl(PyObject *self) | ||
| /*[clinic end generated code: output=e60803ae1cc8621a input=55ce3058e15de393]*/ | ||
| { | ||
| if PyLong_CheckExact(self) { | ||
| return PyTuple_Pack(2, self, _PyLong_One); | ||
| } else { | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing parens on the | ||
| PyObject *numerator = _PyLong_Copy(self); | ||
eric-wieser marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| PyObject *ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_One); | ||
| Py_DECREF(numerator); | ||
| return ratio_tuple; | ||
| } | ||
rhettinger marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
| /*[clinic input] | ||
| int.to_bytes | ||
| @@ -5392,6 +5422,7 @@ static PyMethodDef long_methods[] = { | ||
| #endif | ||
| INT_TO_BYTES_METHODDEF | ||
| INT_FROM_BYTES_METHODDEF | ||
| INT_AS_INTEGER_RATIO_METHODDEF | ||
| {"__trunc__", long_long_meth, METH_NOARGS, | ||
| "Truncating an Integral returns itself."}, | ||
| {"__floor__", long_long_meth, METH_NOARGS, | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add links: