Skip to content

Fix misleading mentions of tp_size in comments - #9093

Merged
benjaminp merged 1 commit into
python:masterfrom
petere:fix-tp_size
Sep 10, 2018
Merged

Fix misleading mentions of tp_size in comments#9093
benjaminp merged 1 commit into
python:masterfrom
petere:fix-tp_size

Conversation

@petere

@peterepetere commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Many type object initializations labeled a field tp_size in the comment, but the name of that field is tp_basicsize.

@petere
Fix misleading mentions of tp_size in comments
c904433
Many type object initializations labeled a field "tp_size" in the
comment, but the name of that field is tp_basicsize.
@benjaminp
benjaminp merged commit 0e0bc4e into python:masterSep 10, 2018
@miss-islington

miss-islington commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Thanks @petere for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Sorry, @petere and @benjaminp, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e0bc4e221f592f305d335faf5f8046484eb9238 3.7

@miss-islington

miss-islington commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Sorry, @petere and @benjaminp, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e0bc4e221f592f305d335faf5f8046484eb9238 3.6

@miss-islington

miss-islington commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

Sorry, @petere and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e0bc4e221f592f305d335faf5f8046484eb9238 2.7

benjaminp pushed a commit that referenced this pull request Sep 10, 2018
@petere@benjaminp
[3.7] Fix misleading mentions of tp_size in comments (GH-9093)
b6a6008
Many type object initializations labeled a field "tp_size" in the
comment, but the name of that field is tp_basicsize..
(cherry picked from commit 0e0bc4e)
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
@bedevere-bot

bedevere-bot commented Sep 10, 2018

Copy link
Copy Markdown

GH-9136 is a backport of this pull request to the 3.7 branch.

benjaminp pushed a commit that referenced this pull request Sep 10, 2018
@petere@benjaminp
[3.6] Fix misleading mentions of tp_size in comments (GH-9093)
444b1cd
Many type object initializations labeled a field "tp_size" in the
comment, but the name of that field is tp_basicsize..
(cherry picked from commit 0e0bc4e)
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
@bedevere-bot

bedevere-bot commented Sep 10, 2018

Copy link
Copy Markdown

GH-9137 is a backport of this pull request to the 3.6 branch.

benjaminp pushed a commit that referenced this pull request Sep 10, 2018
@petere@benjaminp
[2.7] Fix misleading mentions of tp_size in comments (GH-9093)
70013bd
Many type object initializations labeled a field "tp_size" in the
comment, but the name of that field is tp_basicsize..
(cherry picked from commit 0e0bc4e)
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
@bedevere-bot

bedevere-bot commented Sep 10, 2018

Copy link
Copy Markdown

GH-9138 is a backport of this pull request to the 2.7 branch.

@jdemeyerjdemeyer mentioned this pull request May 28, 2019
Merged
@petere
petere deleted the fix-tp_size branch February 12, 2020 10:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettinger
1 more reviewer
@auvipyauvipyauvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminpbenjaminp

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@petere@miss-islington@bedevere-bot@auvipy@benjaminp@the-knights-who-say-ni