Skip to content

gh-90765: Catch LegacyInterpolation deprecation warning - #91480

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation2
May 2, 2022
Merged

gh-90765: Catch LegacyInterpolation deprecation warning#91480
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation2

Conversation

@hugovk

@hugovkhugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member

Follow on from gh-90765, see #30927 (comment).

Before

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparserRaised RLIMIT_NOFILE: 256 -> 10240:00:00 load avg: 5.65 Run tests sequentially0:00:00 load avg: 5.65 [1/1] test_configparser/Users/huvankem/github/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead. interpolation = configparser.LegacyInterpolation()== Tests result: SUCCESS ==1 test OK.Total duration: 476 msTests result: SUCCESS

After

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparserRaised RLIMIT_NOFILE: 256 -> 10240:00:00 load avg: 5.67 Run tests sequentially0:00:00 load avg: 5.67 [1/1] test_configparser== Tests result: SUCCESS ==1 test OK.Total duration: 468 msTests result: SUCCESS

@hugovk
hugovkforce-pushed the issue45173-deprecate-LegacyInterpolation2 branch from 1aefad5 to b820cd5CompareApril 12, 2022 11:11
@ghost

ghost commented Apr 12, 2022

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-botbedevere-bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2022
@hugovkhugovk changed the title bpo-46607: Catch LegacyInterpolation deprecation warninggh-90765: Catch LegacyInterpolation deprecation warningApr 12, 2022
@hugovk
hugovkforce-pushed the issue45173-deprecate-LegacyInterpolation2 branch from b820cd5 to 27d64deCompareApril 12, 2022 11:12
@hugovk
hugovk requested a review from tirkarthiApril 12, 2022 11:14
@hugovk

Copy link
Copy Markdown
MemberAuthor

@tirkarthi Does this need a news file or skip-news label?

@tirkarthitirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hugovk .

@AlexWaygood

Copy link
Copy Markdown
Member

All commit authors signed the Contributor License Agreement. CLA signed

@ambv any idea why the CLA CI check is red, even though the comment here says it's green?

@hugovk

Copy link
Copy Markdown
MemberAuthor

I have already signed the old CLA. When I first created the PR, the CLA comment was red:

image

So I clicked the link to sign the new one anyway. It turned the comment green but not the check:

image

@ambvambv closed this Apr 14, 2022
@ambvambv reopened this Apr 14, 2022
@JelleZijlstra
JelleZijlstra merged commit 56f9844 into python:mainMay 2, 2022
@hugovk
hugovk deleted the issue45173-deprecate-LegacyInterpolation2 branch May 2, 2022 17:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hugovk@AlexWaygood@tirkarthi@ambv@JelleZijlstra@bedevere-bot