Uh oh!
There was an error while loading. Please reload this page.
Add minimal issue templates - #91569
Conversation
AlexWaygood
commented
Apr 15, 2022
(It's the first time I've tried setting up issue templates, so please review carefully.) |
hugovk
left a comment
There was a problem hiding this comment.
Looks good!
To compare with Mypy, will be something like: https://github.com/python/mypy/issues/new/choose
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
left a comment
There was a problem hiding this comment.
One last thing.
We can also skip "please" for brevity.
The Google style guide is pretty good, and says:
https://developers.google.com/style/tone?hl=en#politeness-and-use-of-please
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ezio-melotti
left a comment
There was a problem hiding this comment.
Looks mostly good to me, at least as a first iteration.
A few comments:
- I'm not a big fan of templates with a lot of text and comments, even though I guess they might be more useful for people that are reporting issues for the first time
- If we automatically add labels, it will be more difficult to distinguish triaged and untriaged issues (that currently have no labels) -- do we need to automatically an
untriagedornewlabel for all new issues and remove it once a triager checks them? - We could disable free-form issues, but core-devs might want to use them
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
It looks like there are 179 open issues that have the "build" label, but don't have any of "type-bug", "docs", "type-security" or "type-feature". I think I'd rather not create a |
AlexWaygood
commented
Apr 15, 2022
Neither am I, tbh, but as you say -- they're not really for us; they're for people who are new to CPython :)
We could do that -- I've seen other projects do that. I don't think that's essential, though. CPython has a fairly active group of triagers and core devs who will generally be sifting through recently opened issues anyway. Most of the time, invalidly applied labels will be spotted fairly quickly; and if not, I don't think it's that big a deal anyway. |
ezio-melotti
left a comment
There was a problem hiding this comment.
A couple more nits and then it's good to go:
- I tried to clarify when to use the "crash" template
- I included "enhancements" in the "feature" template
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
AlexWaygood
commented
Apr 16, 2022
Thanks everybody for the reviews! |
Thanks for the PR! It looks like we have 3 security-related entries now: https://github.com/python/cpython/issues/new/choose |
ezio-melotti
commented
Apr 16, 2022
It might actually be better to remove the |
Yup, I think that's best! I had no idea having the |
AlexWaygood
commented
Apr 16, 2022
|
ezio-melotti
commented
Apr 16, 2022
This is because "build" used to be a type on bpo, and now it's a label on its own, since you can have both build-related features and bugs. |
A first step towards:
python/cpythoncore-workflow#437These are largely derived from the mypy issue templates, which I think are pretty effective (more effective than what CPython has currently, anyway 🙂)