Skip to content

gh-69093: Add mapping protocol support to sqlite3.Blob - #91599

Merged
JelleZijlstra merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-blob-add-mapping-protocol
Apr 22, 2022
Merged

gh-69093: Add mapping protocol support to sqlite3.Blob#91599
JelleZijlstra merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-blob-add-mapping-protocol

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Originally written by @palaviv in gh-271.

Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no

gh-69093

@erlend-aasland

erlend-aasland commented Apr 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Let's land GH-91561 first.

Erlend E. Aasland
pythongh-69093: Add mapping protocol support to sqlite3.Blob
38b2cdb
Authored-by: Aviv Palivoda <palaviv@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aasland
erlend-aaslandforce-pushed the sqlite-blob-add-mapping-protocol branch from a84e0fb to 38b2cdbCompareApril 16, 2022 07:15
@JelleZijlstra

JelleZijlstra commented Apr 16, 2022

Copy link
Copy Markdown
Member

Let's land GH-91561 first.

Done, could you fix the conflict? I'll also review the code for this one now.

JelleZijlstra
JelleZijlstra reviewed Apr 16, 2022
View reviewed changes
Comment threadModules/_sqlite/blob.c Outdated
Comment threadModules/_sqlite/blob.c Outdated
Comment threadModules/_sqlite/blob.c
@erlend-aasland
erlend-aasland marked this pull request as draft April 16, 2022 17:56
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 17, 2022 07:53
JelleZijlstra
JelleZijlstra reviewed Apr 17, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
erlend-aasland
erlend-aasland commented Apr 18, 2022
View reviewed changes
Comment threadLib/test/test_sqlite3/test_dbapi.py
@JelleZijlstra
JelleZijlstra self-requested a review April 18, 2022 22:25
JelleZijlstra
JelleZijlstra reviewed Apr 19, 2022
View reviewed changes
Comment threadLib/test/test_sqlite3/test_dbapi.py
Comment threadLib/test/test_sqlite3/test_dbapi.py
Comment threadMisc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bmlMwI.rst Outdated
Comment threadModules/_sqlite/blob.c Outdated
Erlend Egeberg Aasland@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bm…
9cbc339
…lMwI.rst
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
vstinner
vstinner reviewed Apr 19, 2022
View reviewed changes
Comment threadLib/test/test_sqlite3/test_dbapi.py
@JelleZijlstraJelleZijlstra self-assigned this Apr 22, 2022
@JelleZijlstra
JelleZijlstra merged commit 29afb7d into python:mainApr 22, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-blob-add-mapping-protocol branch April 22, 2022 07:44
@erlend-aasland

erlend-aasland commented Apr 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot, Jelle!

@JelleZijlstraJelleZijlstra mentioned this pull request Apr 26, 2022
Merged
@serhiy-storchakaserhiy-storchaka mentioned this pull request May 30, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

@JelleZijlstraJelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@JelleZijlstra@vstinner@bedevere-bot