Skip to content

gh-91860: Add typing.dataclass_transform (PEP 681) - #91861

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep681
Apr 26, 2022
Merged

gh-91860: Add typing.dataclass_transform (PEP 681)#91861
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep681

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Apr 23, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Copied from typing-extensions (python/typing#1054, python/typing#1120).

Documentation is intentionally omitted, so we can focus on getting the
runtime part in before the feature freeze.

#91860

@JelleZijlstra
pythongh-91860: Add typing.dataclass_transform (PEP 681)
9a5bcc3
Copied from typing-extensions (python/typing#1054, python/typing#1120).
Documentation is intentionally omitted, so we can focus on getting the
runtime part in before the feature freeze.
Fidget-Spinner
Fidget-Spinner reviewed Apr 23, 2022
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I just read the PEP and this implementation for the first time. So I'll have some newbie concerns.

Comment threadLib/typing.py Outdated
Comment threadLib/test/test_typing.py
AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and tests look good, just a few comments on the docstring

Comment threadLib/typing.py Outdated
Comment threadLib/typing.py Outdated
Comment threadLib/typing.py
@JelleZijlstra

JelleZijlstra commented Apr 24, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks @Fidget-Spinner and @AlexWaygood for the feedback, I just pushed some changes.

AlexWaygood
AlexWaygood approved these changes Apr 24, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes
Comment threadLib/typing.py Outdated
@AlexWaygoodAlexWaygood added type-feature A feature request or enhancement topic-typing stdlib Standard Library Python modules in the Lib/ directory labels Apr 25, 2022
@JelleZijlstra
JelleZijlstra merged commit 5397b5a into python:mainApr 26, 2022
@JelleZijlstra
JelleZijlstra deleted the pep681 branch April 26, 2022 03:30
@JelleZijlstraJelleZijlstra mentioned this pull request Apr 26, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
typing: Add dataclass_transform
edd2a60
python/cpython#91861
AlexWaygood pushed a commit to python/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
typing: Adddataclass_transform(#7690)
c8a978f
python/cpython#91861
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directorytopic-typingtype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra@Fidget-Spinner@AlexWaygood@bedevere-bot