Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.2k
gh-84461: Improve WebAssembly in-browser demo#91879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
38f7ed9c5365f9292d32c37170bbc99b827738dad43d9048c16d53b02c99fdbbe8a114File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| root = false # This extends the root .editorconfig | ||
| [*.{html,js}] | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 4 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -100,6 +100,7 @@ | ||
| class WasmTerminal { | ||
| constructor() { | ||
| this.inputBuffer = new BufferQueue(); | ||
| this.input = '' | ||
| this.resolveInput = null | ||
| this.activeInput = false | ||
| @@ -123,28 +124,47 @@ | ||
| this.xterm.open(container); | ||
| } | ||
| handleReadComplete(lastChar) { | ||
| this.resolveInput(this.input + lastChar) | ||
| this.activeInput = false | ||
| } | ||
| handleTermData = (data) => { | ||
| if (!this.activeInput) { | ||
| return | ||
| } | ||
| const ord = data.charCodeAt(0); | ||
| let ofs; | ||
| data = data.replace(/\r(?!\n)/g, "\n") // Convert lone CRs to LF | ||
| // Handle pasted data | ||
| if (data.length > 1 && data.includes("\n")) { | ||
| let alreadyWrittenChars = 0; | ||
| // If line already had data on it, merge pasted data with it | ||
| if (this.input != '') { | ||
| this.inputBuffer.addData(this.input); | ||
| alreadyWrittenChars = this.input.length; | ||
| this.input = ''; | ||
| } | ||
| this.inputBuffer.addData(data); | ||
| // If input is active, write the first line | ||
| if (this.activeInput) { | ||
| let line = this.inputBuffer.nextLine(); | ||
| this.writeLine(line.slice(alreadyWrittenChars)); | ||
| this.resolveInput(line); | ||
| this.activeInput = false; | ||
| } | ||
| // When input isn't active, add to line buffer | ||
| } else if (!this.activeInput) { | ||
| // Skip non-printable characters | ||
| if (!(ord === 0x1b || ord == 0x7f || ord < 32)) { | ||
| this.inputBuffer.addData(data); | ||
| } | ||
| // TODO: Handle ANSI escape sequences | ||
| if (ord === 0x1b) { | ||
| } else if (ord === 0x1b) { | ||
| // Handle special characters | ||
| } else if (ord < 32 || ord === 0x7f) { | ||
| switch (data) { | ||
| case "\r": // ENTER | ||
| case "\x0c": // CTRL+L | ||
| this.clear(); | ||
| break; | ||
| case "\n": // ENTER | ||
| case "\x0a": // CTRL+J | ||
| case "\x0d": // CTRL+M | ||
| this.xterm.write('\r\n'); | ||
| this.handleReadComplete('\n'); | ||
| this.resolveInput(this.input + this.writeLine('\n')); | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you explain why you are writing Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe flush on '\n' 0xa only instead of '\r' (0xd) ? or better begin to handle canonical and raw terminal differently as they should. LF should not be treated as EOL.( ncurses and ncursesw will be very soon available on wasm ). Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i also noticed that isatty() is returning 0 for fd 0 / 1 / 2 and it should not at module init before trying to fix something that may not be broken : MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That inconsistency was unintentional. Python seems to have translated I just pushed a commit that normalizes lone The | ||
| this.input = ''; | ||
| this.activeInput = false; | ||
| break; | ||
| case "\x7F": // BACKSPACE | ||
| case "\x08": // CTRL+H | ||
| @@ -157,6 +177,12 @@ | ||
| } | ||
| } | ||
| writeLine(line) { | ||
| this.xterm.write(line.slice(0, -1)) | ||
| this.xterm.write('\r\n'); | ||
| return line; | ||
| } | ||
| handleCursorInsert(data) { | ||
| this.input += data; | ||
| this.xterm.write(data) | ||
| @@ -176,9 +202,19 @@ | ||
| this.activeInput = true | ||
| // Hack to allow stdout/stderr to finish before we figure out where input starts | ||
| setTimeout(() => {this.inputStartCursor = this.xterm.buffer.active.cursorX}, 1) | ||
| // If line buffer has a line ready, send it immediately | ||
| if (this.inputBuffer.hasLineReady()) { | ||
| return new Promise((resolve, reject) => { | ||
| resolve(this.writeLine(this.inputBuffer.nextLine())); | ||
| this.activeInput = false; | ||
| }) | ||
| // If line buffer has an incomplete line, use it for the active line | ||
| } else if (this.inputBuffer.lastLineIsIncomplete()) { | ||
| // Hack to ensure cursor input start doesn't end up after user input | ||
| setTimeout(() => {this.handleCursorInsert(this.inputBuffer.nextLine())}, 1); | ||
| } | ||
| return new Promise((resolve, reject) => { | ||
| this.resolveInput = (value) => { | ||
| this.input = '' | ||
| resolve(value) | ||
| } | ||
| }) | ||
| @@ -188,9 +224,44 @@ | ||
| this.xterm.clear(); | ||
| } | ||
| print(message) { | ||
| const normInput = message.replace(/[\r\n]+/g, "\n").replace(/\n/g, "\r\n"); | ||
| this.xterm.write(normInput); | ||
| print(charCode) { | ||
| let array = [charCode]; | ||
| if (charCode == 10) { | ||
| array = [13, 10]; // Replace \n with \r\n | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. python should send \r\n not \n, line should be cooked for a terminal on stdout. add a workaround or fix tty detection in emscripten ? MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When I remove that When I did a if (charCode==10) {
console.log('Saw LF');
array= [13, 10]; //Replace \nwith \r\n
} elseif (charCode==13) {
console.log('Saw CR');
}Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's a problem with emscripten Module I/O registration, i'm not sure but it may have to do with something like TTY.register() could not find much apart from a vague mention that it does not have any doc see emscripten-core/emscripten#6861
| ||
| } | ||
| this.xterm.write(new Uint8Array(array)); | ||
| } | ||
| } | ||
| class BufferQueue { | ||
| constructor(xterm) { | ||
| this.buffer = [] | ||
| } | ||
| isEmpty() { | ||
| return this.buffer.length == 0 | ||
| } | ||
| lastLineIsIncomplete() { | ||
| return !this.isEmpty() && !this.buffer[this.buffer.length-1].endsWith("\n") | ||
| } | ||
| hasLineReady() { | ||
| return !this.isEmpty() && this.buffer[0].endsWith("\n") | ||
| } | ||
| addData(data) { | ||
| let lines = data.match(/.*(\n|$)/g) | ||
| if (this.lastLineIsIncomplete()) { | ||
| this.buffer[this.buffer.length-1] += lines.shift() | ||
| } | ||
| for (let line of lines) { | ||
| this.buffer.push(line) | ||
| } | ||
| } | ||
| nextLine() { | ||
| return this.buffer.shift() | ||
| } | ||
| } | ||
| @@ -202,8 +273,8 @@ | ||
| terminal.open(document.getElementById('terminal')) | ||
| const stdio = { | ||
| stdout: (s) => { terminal.print(s) }, | ||
| stderr: (s) => { terminal.print(s) }, | ||
| stdout: (charCode) => { terminal.print(charCode) }, | ||
| stderr: (charCode) => { terminal.print(charCode) }, | ||
| stdin: async () => { | ||
| return await terminal.prompt() | ||
| } | ||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure that file is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that it's not strictly required, but CPython already has a root
.editorconfigfile which informs text editors of the indentation and whitespace style to use. The root file doesn't have rules for HTML and JS files, which I noticed because my editor had a default setup that was inserting 2 spaces when I hit tab in these files.I'm not sure whether the other
*.jsand*.htmlfiles in this repository use 4 spaces consistently, so I made a local.editorconfigfile instead of adding to the root one.