Skip to content

gh-84461: Add HOSTRUNNER for program to run Python executable - #91931

Merged
miss-islington merged 6 commits into
python:mainfrom
emmatyping:hostrunner
Apr 28, 2022
Merged

gh-84461: Add HOSTRUNNER for program to run Python executable#91931
miss-islington merged 6 commits into
python:mainfrom
emmatyping:hostrunner

Conversation

@emmatyping

@emmatypingemmatyping commented Apr 25, 2022

Copy link
Copy Markdown
Member

HOSTRUNNER is a program which can be used to run BUILDPYTHON for the host platform (for example, python.js requires node).

Also change depedencies from build_all to all so that targets which can't build everything (e.g. WASM) can still run buildbottest and pythoninfo.

cc @tiran

Automerge-Triggered-By: GH:tiran

@tirantiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add [] around arguments.
  • Fix whitespace / tab
  • You need to AC_SUBST variables to make configure substitute the variable in templates.
  • Threaded builds need additional arguments to enable experimental threading and shared buffers
AS_VAR_IF([enable_wasm_pthreads], [yes], [
HOSTRUNNER='node --experimental-wasm-threads --experimental-wasm-bulk-memory'
], [
HOSTRUNNER='node'
])

Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
emmatypingand others added 3 commits April 27, 2022 13:08
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Comment threadconfigure.ac Outdated
emmatypingand others added 2 commits April 27, 2022 14:06
Co-authored-by: Christian Heimes <christian@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@emmatyping@tiran@bedevere-bot@miss-islington