Skip to content

gh-68966: Deprecate the mailcap module - #91951

Merged
vstinner merged 4 commits into
python:mainfrom
vstinner:deprecate_mailcap
Apr 26, 2022
Merged

gh-68966: Deprecate the mailcap module#91951
vstinner merged 4 commits into
python:mainfrom
vstinner:deprecate_mailcap

Conversation

@vstinner

@vstinnervstinner commented Apr 26, 2022

Copy link
Copy Markdown
Member

No description provided.

@vstinner
vstinner requested a review from a team as a code ownerApril 26, 2022 07:11
@vstinnervstinner mentioned this pull request Apr 26, 2022
Closed
@vstinner

vstinner commented Apr 26, 2022

Copy link
Copy Markdown
MemberAuthor

cc @brettcannon@hugovk

mimetypes is not a replacement, but provide a "similar" feature. mailcap opens a file with an application, whereas mimetypes gets the MIME type of a file. On Linux, the xdg-open program is an alternative, but it's not portable.

@vstinner

vstinner commented Apr 26, 2022

Copy link
Copy Markdown
MemberAuthor

I updated the doc to mention PEP 594 for the rationale. I didn't mention PEP 594 in the deprecation message.

@vstinner

vstinner commented Apr 26, 2022

Copy link
Copy Markdown
MemberAuthor

The Steering Council decided to deprecate the mailcap module as part of PEP 594, so in Python 3.11:

@vstinnervstinner mentioned this pull request Apr 26, 2022
Closed
hugovk
hugovk reviewed Apr 26, 2022
View reviewed changes
Comment threadDoc/whatsnew/3.11.rst Outdated
be able to parse Python 3.10 or newer. See the :pep:`617` (New PEG parser for
CPython). (Contributed by Victor Stinner in :issue:`40360`.)

* The :mod:`mailcap` module is now deprecated and will be removed in Python

@hugovkhugovkApr 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe list this with the other two PEP 594 ones below?

@hugovk

hugovk commented Apr 26, 2022

Copy link
Copy Markdown
Member

For the others, the documentation changes was done separately (and also list on Doc/library/superseded.rst), so they could be backported to 3.9 and 3.10.

For example, see #31891 and #31984.

The SC also wanted to leave out the targeted removal date in docs (but not warnings): #31891 (comment)

Please could you split the PR?

@vstinner

vstinner commented Apr 26, 2022

Copy link
Copy Markdown
MemberAuthor

@hugovk: I updated my PR. Would you mind to review it again?

hugovk
hugovk requested changes Apr 26, 2022
View reviewed changes
Comment threadDoc/library/mailcap.rst
Comment threadDoc/whatsnew/3.11.rst

(Contributed by Brett Cannon in :issue:`47061`.)
(Contributed by Brett Cannon in :issue:`47061` and Victor Stinner in
:gh:`68966`.)

@hugovkhugovkApr 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the others, we should include these 3.11.rst changes in the 2nd PR that'll do the code warnings, because we don't want to backport this bit.

@vstinnervstinnerApr 26, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to modify the backport but push all changes at once in the main branch.

Comment threadLib/mailcap.py
_DEPRECATION_MSG = ('The {name} module is deprecated and will be removed in '
'Python {remove}. See the mimetypes module for an '
'alternative.')
warnings._deprecated(__name__, _DEPRECATION_MSG, remove=(3, 13))

@hugovkhugovkApr 26, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this in a 2nd, non-backport PR.

Comment threadLib/test/test_mailcap.py Outdated
with warnings.catch_warnings():
# mailcap is deprecated
warnings.simplefilter('ignore', DeprecationWarning)
import mailcap

@hugovkhugovkApr 26, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changes to this file for the 2nd PR.

hugovk
hugovk reviewed Apr 26, 2022
View reviewed changes
Comment threadLib/test/test_mailcap.py Outdated
hugovk
hugovk approved these changes Apr 26, 2022
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vstinner
vstinner merged commit 80de027 into python:mainApr 26, 2022
@vstinner
vstinner deleted the deprecate_mailcap branch April 26, 2022 20:43
@vstinner

vstinner commented Apr 26, 2022

Copy link
Copy Markdown
MemberAuthor

@hugovk: I created #91971 for Python 3.10.

@hugovkhugovk mentioned this pull request May 2, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@hugovk@brettcannon@bedevere-bot