Uh oh!
There was an error while loading. Please reload this page.
gh-91928: Add datetime.UTC alias for datetime.timezone.utc - #91973
Conversation
bedevere-bot
commented
Apr 27, 2022
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
pganssle
left a comment
There was a problem hiding this comment.
This looks great, thanks!
In addition to my other comments, two other things:
- As I believe you are a first-time contributor, you should probably add your name to Misc/ACKS.
- Maybe add a very simple test to
TestModule, like this:
deftest_utc_alias(self):
self.assertIs(UTC, timezone.utc)Thanks for your contribution!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Apr 27, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Kab1r
commented
Apr 27, 2022
I have made the requested changes; please review again |
bedevere-bot
commented
Apr 27, 2022
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
pganssle
left a comment
There was a problem hiding this comment.
Can you add this test?
Maybe add a very simple test to TestModule, like this:
deftest_utc_alias(self): self.assertIs(UTC, timezone.utc)
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Apr 27, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Kab1r
commented
Apr 27, 2022
I had to move the definition of |
Kab1r
commented
Apr 27, 2022
I have made the requested changes; please review again |
bedevere-bot
commented
Apr 27, 2022
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
1. Add UTC definition into C implementation as well (just for consistency, there's no particular reason not to simply assign the alias in the Python code later). 2. Move `..versionadded` tag into the right place
c097669 to
9542f54Comparepganssle
commented
May 3, 2022
Thanks @Kab1r! |
Resolves an issue Ken reported running tests in the QA farm, which is due to use of an interface from more-recent-python: python/cpython#91973
fixes#91928
UTCis now module attribute aliased todatetime.timezone.utc.You can now do the following:
Automerge-Triggered-By: GH:pganssle