Skip to content

[2.7] bpo-28994: Remove mistakenly backported atexitmodule.c - #9214

Merged
serhiy-storchaka merged 2 commits into
python:2.7from
ZackerySpytz:bpo-28994-atexitmodule-2.7
Sep 12, 2018
Merged

[2.7] bpo-28994: Remove mistakenly backported atexitmodule.c#9214
serhiy-storchaka merged 2 commits into
python:2.7from
ZackerySpytz:bpo-28994-atexitmodule-2.7

Conversation

@ZackerySpytz

@ZackerySpytzZackerySpytz commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

It was backported in 0cc43df.

I believe the test added in that commit can stay, however.

https://bugs.python.org/issue28994

@serhiy-storchaka

Copy link
Copy Markdown
Member

Good catch! Maybe remove also the NEWS entry?

@ZackerySpytz

Copy link
Copy Markdown
ContributorAuthor

Good catch!

Someone had reported it at GH-2123.

@serhiy-storchakaserhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news labels Sep 12, 2018
@orivej

Copy link
Copy Markdown
Contributor

Thank you! Could you also remove Objects/bytesobject.c (here or in another PR), introduced in #4163. It was accidentally backported from an immaterially changed a231428#diff-aac9159c0ef71bb482b19ca5c07e2f3d

@Jackeloves

Copy link
Copy Markdown

路过。。。。

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz@serhiy-storchaka@orivej@Jackeloves@the-knights-who-say-ni@bedevere-bot