Uh oh!
There was an error while loading. Please reload this page.
[3.11] gh-91162: Fix substitution of unpacked tuples in generic aliases (GH-92335) - #92484
Conversation
miss-islington
commented
May 8, 2022
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
miss-islington
commented
May 8, 2022
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
1 similar comment
miss-islington
commented
May 8, 2022
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
Fidget-Spinner
commented
May 8, 2022
Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to lookup the C CC @pablogsal |
pablogsal
commented
May 8, 2022
In this case, you can regenerate the ABI, but this will not be possible in the RC state |
miss-islington
commented
May 8, 2022
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
serhiy-storchaka
commented
May 31, 2022
How to merge this PR? |
Fidget-Spinner
commented
May 31, 2022
@serhiy-storchaka please see this message, or the whole bpo issue. In the past, I had to get @pablogsal to regenerate it, because we don't have a devguide article on this and I was confused. |
pablogsal
commented
May 31, 2022
I will merge this today. Will also try to add some information to the devguide, but in general the RM needs to approve ABI regenerations. |
pythonGH-92335) (cherry picked from commit 9d25db9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
612e03d to
8024c08Compare
(cherry picked from commit 9d25db9)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com