Skip to content

gh-92525: make inspect.getfile PEP 420 compliant - #92635

Open
carlbordum wants to merge 3 commits into
python:mainfrom
carlbordum:92525-inspect-getfile-pop-420
Open

gh-92525: make inspect.getfile PEP 420 compliant#92635
carlbordum wants to merge 3 commits into
python:mainfrom
carlbordum:92525-inspect-getfile-pop-420

Conversation

@carlbordum

@carlbordumcarlbordum commented May 10, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

serhiy-storchaka
serhiy-storchaka requested changes May 11, 2022
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test and a NEWS entry.

@bedevere-bot

bedevere-bot commented May 11, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@carlbordum
carlbordumforce-pushed the 92525-inspect-getfile-pop-420 branch from 0efd3c7 to 89b2b45CompareMay 11, 2022 15:54
@carlbordum

carlbordum commented May 11, 2022

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 11, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed May 11, 2022
View reviewed changes
Comment threadLib/test/test_inspect.py Outdated
Comment threadLib/test/test_inspect.py Outdated
@carlbordum
carlbordumforce-pushed the 92525-inspect-getfile-pop-420 branch from 89b2b45 to 0b4953eCompareMay 21, 2022 19:07
@carlbordum
carlbordumforce-pushed the 92525-inspect-getfile-pop-420 branch 2 times, most recently from e8c07a1 to d6b227dCompareSeptember 1, 2022 18:48
@carlbordum
carlbordumforce-pushed the 92525-inspect-getfile-pop-420 branch from d6b227d to 9aaf28cCompareSeptember 1, 2022 19:39
@carlbordum

carlbordum commented Sep 1, 2022

Copy link
Copy Markdown
ContributorAuthor

What do you think of this? Should something more be tested?

@bedevere-appbedevere-appBot mentioned this pull request Dec 15, 2023
Open
@github-actions

github-actionsBot commented Apr 11, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka requested changes

Assignees

No one assigned

Labels

awaiting change reviewstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlbordum@bedevere-bot@serhiy-storchaka