Uh oh!
There was an error while loading. Please reload this page.
gh-92584: test_cppext uses setuptools - #92639
Merged
Merged
Conversation
Rewrite test_cppext to run in a virtual environment and to build the C++ extension with setuptools rather than distutils.
vstinner
commented
May 10, 2022
MemberAuthor
If this approach works and is accepted, we can use the same for test_peg_generator. |
FFY00
commented
May 11, 2022
Member
What happens if CPython for some reason breaks setuptools? |
vstinner
commented
May 11, 2022
MemberAuthor
The test fails which is a good thing :-) |
vstinner
commented
May 12, 2022
MemberAuthor
Let's try and see how it goes :-) |
vstinner
commented
May 16, 2022
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite test_cppext to run in a virtual environment and to build the
C++ extension with setuptools rather than distutils.