Uh oh!
There was an error while loading. Please reload this page.
[3.11] Restore default role check in make check. (GH-92290) - #92821
Merged
Conversation
* Restore default role check in `make check`. * Options first, then files. * Update `make.bat` too. * Add a comment explaining the extra options. * No reason to ignore the README.rst. * Enable default-role check in sphinx-lint. Co-authored-by: Julien Palard <julien@palard.fr> * Update sphinx-lint default-role check. * Fix use of the default role in the docs. * Update make.bat to check for the default role too. * Fix comment in make.bat. Co-authored-by: Julien Palard <julien@palard.fr> (cherry picked from commit 953ab07) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti
requested review from
abalkin, ethanfurman and pganssle
as code ownersMay 15, 2022 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore default role check in
make check.Options first, then files.
Update
make.battoo.Add a comment explaining the extra options.
No reason to ignore the README.rst.
Enable default-role check in sphinx-lint.
Co-authored-by: Julien Palard julien@palard.fr
Update sphinx-lint default-role check.
Fix use of the default role in the docs.
Update make.bat to check for the default role too.
Fix comment in make.bat.
Co-authored-by: Julien Palard julien@palard.fr
(cherry picked from commit 953ab07)
Co-authored-by: Ezio Melotti ezio.melotti@gmail.com