Uh oh!
There was an error while loading. Please reload this page.
gh-93156: fix negative indexing into absolute pathlib.PurePath().parents - #93273
Merged
Merged
Conversation
…h().parents` When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices.
pathlib.PurePath().parentspathlib.PurePath().parentsAA-Turner
commented
May 26, 2022
Member
@barneygale should this be backported? A |
barneygale
commented
May 26, 2022
ContributorAuthor
Yep - 3.11 and 3.10 are also affected. |
Uh oh!
There was an error while loading. Please reload this page.
brettcannon
approved these changes
Jun 3, 2022
miss-islington
commented
Jun 3, 2022
Contributor
Thanks @barneygale for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2022
…h().parents` (pythonGH-93273) When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices. (cherry picked from commit f32e6b4) Co-authored-by: Barney Gale <barney.gale@gmail.com>
bedevere-bot
commented
Jun 3, 2022
GH-93479 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2022
…h().parents` (pythonGH-93273) When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices. (cherry picked from commit f32e6b4) Co-authored-by: Barney Gale <barney.gale@gmail.com>
bedevere-bot
commented
Jun 3, 2022
GH-93480 is a backport of this pull request to the 3.10 branch. |
miss-islington added a commit
that referenced
this pull request
Jun 3, 2022
…rents` (GH-93273) When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices. (cherry picked from commit f32e6b4) Co-authored-by: Barney Gale <barney.gale@gmail.com>
miss-islington added a commit
that referenced
this pull request
Jun 3, 2022
…rents` (GH-93273) When a `_PathParents` object has a drive or a root, the length of the object is *one less* than than the length of `self._parts`, which resulted in an off-by-one error when `path.parents[-n]` was fed through to `self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed path object with spooky properties. This is addressed by adding `len(self)` to negative indices. (cherry picked from commit f32e6b4) Co-authored-by: Barney Gale <barney.gale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
_PathParentsobject has a drive or a root, the length of the object is one less than than the length ofself._parts, which resulted in an off-by-one error whenpath.parents[-n]was fed through toself._parts[:-n - 1]. In particular,path.parents[-1]was a malformed path object with spooky properties.This is addressed by adding
len(self)to negative indices.Issue link: #93156