Skip to content

gh-92597: Ensure that AST nodes without explicit end positions can be compiled - #93359

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-92597
May 31, 2022
Merged

gh-92597: Ensure that AST nodes without explicit end positions can be compiled#93359
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-92597

Conversation

@pablogsal

@pablogsalpablogsal commented May 30, 2022

Copy link
Copy Markdown
Member

Closes: #92597

@pablogsalpablogsal added the needs backport to 3.11 only security fixes label May 30, 2022
@pablogsal
pablogsalforce-pushed the gh-92597 branch 4 times, most recently from 47bf959 to 4fa8695CompareMay 30, 2022 19:01
arhadthedev
arhadthedev reviewed May 30, 2022
View reviewed changes
Comment threadParser/asdl_c.py
arhadthedev
arhadthedev reviewed May 30, 2022
View reviewed changes
Comment threadParser/asdl_c.py
@pablogsalpablogsal mentioned this pull request May 31, 2022
Closed
@nedbat

nedbat commented May 31, 2022

Copy link
Copy Markdown
Member

I can confirm that this fixes #93387.

@nedbatnedbat mentioned this pull request May 31, 2022
Closed
@pablogsal
pablogsal merged commit 705eaec into python:mainMay 31, 2022
@pablogsal
pablogsal deleted the gh-92597 branch May 31, 2022 23:00
@miss-islington

miss-islington commented May 31, 2022

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2022
@pablogsal@miss-islington
pythongh-92597: Ensure that AST nodes without explicit end positions …
a3156c6
…can be compiled (pythonGH-93359)
(cherry picked from commit 705eaec)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented May 31, 2022

Copy link
Copy Markdown

GH-93397 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 31, 2022
miss-islington added a commit that referenced this pull request May 31, 2022
@miss-islington@pablogsal
gh-92597: Ensure that AST nodes without explicit end positions can be…
b425d88
… compiled (GH-93359)
(cherry picked from commit 705eaec)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@C4ptainCrunchC4ptainCrunch mentioned this pull request Jun 1, 2022
Open
9 tasks
@hugovkhugovk mentioned this pull request Jun 1, 2022
Merged
@davidhewittdavidhewitt mentioned this pull request Jun 1, 2022
Merged
LeMyst added a commit to LeMyst/WikibaseIntegrator that referenced this pull request Jun 1, 2022
@LeMyst
Disable pytest on 3.11-dev
549008e
Solved in python/cpython#93359
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments
@isidenticalisidenticalAwaiting requested review from isidentical
@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash on AST with misordered linenos

5 participants

@pablogsal@nedbat@miss-islington@bedevere-bot@arhadthedev