Uh oh!
There was an error while loading. Please reload this page.
[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) - #93651
Conversation
…ing spawn (pythonGH-30617) Co-authored-by: XD Trol <milestonejxd@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> (cherry picked from commit 30610d2) Co-authored-by: Leo Trol <milestone.jxd@gmail.com>
miss-islington
commented
Jun 9, 2022
miss-islington
commented
Jun 9, 2022
pitrou
commented
Jun 9, 2022
@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR? |
vstinner
commented
Jun 9, 2022
vs
One email has a dot, not the other. I don't know what's going on. @ambv: Do you have an idea why the email address is different and the CLA check fails? |
miss-islington
commented
Jun 9, 2022
miss-islington
commented
Jun 10, 2022
Status check is done, and it's a success ✅ . |
CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not. |
bedevere-bot
commented
Jun 10, 2022
miss-islington
commented
Jun 10, 2022
Status check is done, and it's a success ✅ . |
vstinner
left a comment
There was a problem hiding this comment.
LGTM, backport from main branch.
ambv
commented
Jun 10, 2022
The CLA bot should probably also ignore dots in emails. |
ambv
commented
Jun 10, 2022
@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local |
miss-islington
commented
Jun 10, 2022
pitrou
commented
Jun 10, 2022
test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner |
miss-islington
commented
Jun 10, 2022
Status check is done, and it's a success ✅ . |
ambv
commented
Jun 10, 2022
@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them. |
jxdabc
commented
Jun 14, 2022
Yes, the email address in ~/.gitconfig does differ from GitHub account email address. |
Co-authored-by: XD Trol milestonejxd@gmail.com
Co-authored-by: Antoine Pitrou pitrou@free.fr
(cherry picked from commit 30610d2)
Co-authored-by: Leo Trol milestone.jxd@gmail.com