Skip to content

gh-93963: Officially deprecate abcs and warn about their usage. - #93965

Merged
miss-islington merged 5 commits into
mainfrom
gh-93963/deprecate-importlib-resources-abcs
Jul 3, 2022
Merged

gh-93963: Officially deprecate abcs and warn about their usage.#93965
miss-islington merged 5 commits into
mainfrom
gh-93963/deprecate-importlib-resources-abcs

Conversation

@jaraco

@jaracojaraco commented Jun 17, 2022

Copy link
Copy Markdown
Member

@jaracojaraco added the needs backport to 3.11 only security fixes label Jun 17, 2022
@jaraco
jaracoforce-pushed the gh-93963/deprecate-importlib-resources-abcs branch from 2064d07 to 7890672CompareJune 17, 2022 20:14
@jaraco
jaracoforce-pushed the gh-93963/deprecate-importlib-resources-abcs branch from 7890672 to 5e7fb9cCompareJune 17, 2022 20:23
Comment threadLib/importlib/abc.py Outdated
Co-authored-by: Thomas Grainger <tagrain@gmail.com>

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadLib/importlib/abc.py Outdated
@hugovk

Copy link
Copy Markdown
Member

According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

@warsawwarsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions.

Comment threadLib/importlib/abc.py
Comment threadLib/importlib/abc.py Outdated
Comment threadLib/importlib/abc.py
@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@encukou

Copy link
Copy Markdown
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

@warsaw

Copy link
Copy Markdown
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

From a backward compatibility question, none. But we should be crisp in the documentation about where the proper place to import them from is, and add deprecations for the old places.

@jaraco

Copy link
Copy Markdown
MemberAuthor

According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

Yes, although I contend it would be preferable to deprecate these in 3.11 for removal in 3.13, given that is the prior intention.

@hugovk

Copy link
Copy Markdown
Member

Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11.

@pablogsal

Copy link
Copy Markdown
Member

Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11.

Indeed, unfortunately is too late to add new deprecations to 3.11, specially given how unstable 3.11 is already. Sadly this needs to be done starting in 3.12 :(

@jaracojaraco removed the needs backport to 3.11 only security fixes label Jul 3, 2022
Comment threadLib/importlib/abc.py Outdated
@jaraco

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

@miss-islington
miss-islington merged commit 71848c9 into mainJul 3, 2022
@miss-islington
miss-islington deleted the gh-93963/deprecate-importlib-resources-abcs branch July 3, 2022 19:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Officially deprecate and remove abcs in importlib.abc moved to importlib.resources.

8 participants

@jaraco@hugovk@bedevere-bot@encukou@warsaw@pablogsal@graingert@miss-islington