Uh oh!
There was an error while loading. Please reload this page.
gh-93963: Officially deprecate abcs and warn about their usage. - #93965
Conversation
2064d07 to
7890672Compare7890672 to
5e7fb9cCompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
hugovk
left a comment
There was a problem hiding this comment.
Please could you note the deprecations in https://docs.python.org/3.12/library/importlib.html with deprecated-removed?
and list under https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-python-3-13 ?
Uh oh!
There was an error while loading. Please reload this page.
hugovk
commented
Jun 17, 2022
According to PEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Jun 17, 2022
When you're done making the requested changes, leave the comment: |
encukou
commented
Jun 27, 2022
Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places? |
warsaw
commented
Jun 27, 2022
From a backward compatibility question, none. But we should be crisp in the documentation about where the proper place to import them from is, and add deprecations for the old places. |
jaraco
commented
Jul 2, 2022
Yes, although I contend it would be preferable to deprecate these in 3.11 for removal in 3.13, given that is the prior intention. |
hugovk
commented
Jul 3, 2022
Okay! I thought the 3.11 beta period was too late for new deprecations, but let's check with @pablogsal to see if this can be backported to 3.11. |
pablogsal
commented
Jul 3, 2022
Indeed, unfortunately is too late to add new deprecations to 3.11, specially given how unstable 3.11 is already. Sadly this needs to be done starting in 3.12 :( |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
jaraco
commented
Jul 3, 2022
I have made the requested changes; please review again. |
bedevere-bot
commented
Jul 3, 2022
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
Fixes#93963
Automerge-Triggered-By: GH:jaraco