gh-54781: Move Lib/tkinter/test/test_ttk/ to Lib/test/test_ttk/ by vstinner · Pull Request #94070 · python/cpython

vstinner · 2022-06-21T15:39:30Z

Move Lib/tkinter/test/ to Lib/test/test_tkinter/.

Rename test_tk to test_tkinter, and rename test_ttk_guionly to test_ttk.

Move test sub-packages to Lib/test #54781

vstinner · 2022-06-21T15:41:05Z

I can still run tests on an newly installed (patched) Python 3.12:

$ /opt/py3.12/bin/python3.12 -m test test_tkinter -u all -v
(...)
Ran 731 tests in 6.853s
$ /opt/py3.12/bin/python3.12 -m test test_ttk -u all -v
(...)
Ran 308 tests in 7.905s
$ /opt/py3.12/bin/python3.12 -m test test_tkinter
test_tkinter skipped -- Use of the 'gui' resource not enabled
test_tkinter skipped (resource denied)
$ /opt/py3.12/bin/python3.12 -m test test_ttk
test_ttk skipped -- Use of the 'gui' resource not enabled
test_ttk skipped (resource denied)

vstinner · 2022-06-21T15:42:19Z

Rename test_tk to test_tkinter

For me, it's disturbing when tests don't have the same name than the tested module. asyncio => test_asyncio. tkinter => test_tk ???

rename test_ttk_guionly to test_ttk

I can keep test_ttk_guionly name if you prefer, but for me, tests should use the GUI. Only the special tests test_ttk_textonly should have a special name, no?

vstinner · 2022-06-21T15:42:32Z

cc @terryjreedy @serhiy-storchaka

vstinner · 2022-06-21T15:46:43Z

This PR is special. I made the new directory tree "flat". support.py and test_simpledialog.py now lives in Lib/test/test_tkinter/. Previously, test_simpledialog.py was in a test_tkinter/ sub-directory.

Before:

Lib/tkinter/test/
Lib/tkinter/test/README
Lib/tkinter/test/__init__.py
Lib/tkinter/test/support.py
Lib/tkinter/test/test_tkinter
Lib/tkinter/test/test_tkinter/__init__.py
Lib/tkinter/test/test_tkinter/test_colorchooser.py
Lib/tkinter/test/test_tkinter/test_font.py
Lib/tkinter/test/test_tkinter/test_geometry_managers.py
Lib/tkinter/test/test_tkinter/test_images.py
Lib/tkinter/test/test_tkinter/test_loadtk.py
Lib/tkinter/test/test_tkinter/test_messagebox.py
Lib/tkinter/test/test_tkinter/test_misc.py
Lib/tkinter/test/test_tkinter/test_simpledialog.py
Lib/tkinter/test/test_tkinter/test_text.py
Lib/tkinter/test/test_tkinter/test_variables.py
Lib/tkinter/test/test_tkinter/test_widgets.py
Lib/tkinter/test/test_ttk
Lib/tkinter/test/test_ttk/__init__.py
Lib/tkinter/test/test_ttk/test_extensions.py
Lib/tkinter/test/test_ttk/test_style.py
Lib/tkinter/test/test_ttk/test_widgets.py
Lib/tkinter/test/widget_tests.py

After:

Lib/test/test_ttk/
Lib/test/test_ttk/__init__.py
Lib/test/test_ttk/test_extensions.py
Lib/test/test_ttk/test_style.py
Lib/test/test_ttk/test_widgets.py
Lib/test/test_tkinter/
Lib/test/test_tkinter/README
Lib/test/test_tkinter/__init__.py
Lib/test/test_tkinter/support.py
Lib/test/test_tkinter/test_colorchooser.py
Lib/test/test_tkinter/test_font.py
Lib/test/test_tkinter/test_geometry_managers.py
Lib/test/test_tkinter/test_images.py
Lib/test/test_tkinter/test_loadtk.py
Lib/test/test_tkinter/test_messagebox.py
Lib/test/test_tkinter/test_misc.py
Lib/test/test_tkinter/test_simpledialog.py
Lib/test/test_tkinter/test_text.py
Lib/test/test_tkinter/test_variables.py
Lib/test/test_tkinter/test_widgets.py
Lib/test/test_tkinter/widget_tests.py

vstinner · 2022-06-21T15:49:37Z

Windows (x64) job failed but I cannot get the logs. I cancelled the workflow. I still cannot see the logs. Strange.

zware · 2022-06-21T15:51:23Z

Windows (x64) job failed but I cannot get the logs. I cancelled the workflow. I still cannot see the logs. Strange.

The failure is unrelated, see #94068.

vstinner · 2022-06-21T16:00:19Z

Oh. Windows build failed with an unrelated error:

Error: D:\a\cpython\cpython\Modules\socketmodule.c(7475,5): error C2065: 'HVSOCKET_CONTAINER_PASSTHRU': undeclared identifier [D:\a\cpython\cpython\PCbuild_socket.vcxproj]

zooba · 2022-06-21T16:01:50Z

Yeah, seems we're in the middle of the rollout of new CI images, so there's a chance you'll get the older image and not see the error. But you'll need my PR for it to be reliable.

serhiy-storchaka · 2022-06-21T15:59:54Z

Does python -m test.test_tkinter still work?

It would work if a __main__ module gets added. But it was test.test_tk before, not test.test_tkinter.

Ah you care about this command? If you do, I can add a __main__.py file.

Yes, please add it. And test different ways of running tests:
python -m test.test_xxx python -m unittest test.test_xxx python -m test test_xxx

I added __main__ sub-modules. Example:
./python -m test.test_ttk -v ./python -m test test_ttk -v -u all ./python -m unittest test.test_ttk -v
The 3 commands end with: Ran 308 tests.

serhiy-storchaka · 2022-06-21T16:04:34Z

Why not use just loader.discover()?

I copy/paste the code from test_asyncio, it works, so I didn't change it :-)

Does loader.discover() work with zipimport?

Does loader.discover() work with zipimport?
I have no idea. If there is an issue, I suggest to fix all load_tests() functions of Lib/test/ in a separated PR.

serhiy-storchaka · 2022-06-21T16:12:39Z

Should it be backported?

terryjreedy · 2022-06-21T16:20:22Z

I would prefer that ttk tests be included under test_tkinter, with names like test_ttk_widgets, so that python -m test.test_tkinter (and python -m test -ugui test_tkinter) tests everything. But re-organization details are up to Serhiy.

terryjreedy · 2022-06-21T16:25:55Z

This patch will require changes to the scripts *nix distributions use to make tkinter (and IDLE) a separate install. I don't know how they would feel about backports.

vstinner · 2022-06-21T17:41:41Z

I rebased the PR to get the fix for the Windows build: #94068

vstinner · 2022-06-21T17:43:48Z

Should it be backported?

This specific PR change the name of two tests, so no, it should not be backported.

It also changes the build system (Linux, VS project). Honestly, it sounds risky and I would prefer to not backport it.

vstinner · 2022-06-21T17:45:05Z

I would prefer that ttk tests be included under test_tkinter

Oh. I tried to minimize changes in this PR. But I'm open to reorganizing tests.

@serhiy-storchaka: Are you fine with the 2 proposed tests, or do you want to merge them?

vstinner · 2022-06-21T17:46:35Z

This patch will require changes to the scripts *nix distributions use to make tkinter (and IDLE) a separate install. I don't know how they would feel about backports.

Once issue #54781 will be fixed, I will properly document these changes in What's New in Python 3.12. IMO it fits into the Build Changes section.

serhiy-storchaka · 2022-06-21T19:32:55Z

Are you fine with the 2 proposed tests, or do you want to merge them?

I was going to ask about merging them, but I am fine with the current state of this PR. If you are going to merge test_ttk into test_tkinter, do not forget about test_tcl.

Maybe do this in a separate PR?

vstinner · 2022-06-21T20:22:54Z

I was going to ask about merging them, but I am fine with the current state of this PR. If you are going to merge test_ttk into test_tkinter, do not forget about test_tcl.

Oh, merging 3 Tkinter tests sound out of my skills. I don't know well this module and I would prefer if someone else do it.

Here I'm trying to focus on fixing the 12 years old issue #54781 :-) Perfect is the enemy of good ;-)

vstinner · 2022-06-21T21:30:46Z

@serhiy-storchaka: Does it look good to you like that?

vstinner · 2022-06-22T16:08:23Z

@serhiy-storchaka wrote "I am fine with the current state of this PR". I plan to merge the PR tomorrow if I don't hear back from @serhiy-storchaka.

* Add Lib/test/test_ttk/__init__.py based on test_ttk_guionly.py. * Remove Lib/test/test_ttk_guionly.py.

Remove Lib/test/test_tk.py.

python/cpython#94070

vstinner requested a review from a team as a code owner June 21, 2022 15:39

bedevere-bot added the awaiting core review label Jun 21, 2022

vstinner mentioned this pull request Jun 21, 2022
Move test sub-packages to Lib/test #54781
Closed

serhiy-storchaka requested review from serhiy-storchaka and removed request for a teamJune 21, 2022 15:54

vstinner closed this Jun 21, 2022

vstinner reopened this Jun 21, 2022

serhiy-storchaka reviewed Jun 21, 2022
View reviewed changes

vstinner added 3 commits June 22, 2022 19:14

gh-54781: Move Lib/tkinter/test/test_ttk/ to Lib/test/test_ttk/
9844364
* Add Lib/test/test_ttk/__init__.py based on test_ttk_guionly.py. * Remove Lib/test/test_ttk_guionly.py.

Move Lib/tkinter/test/ to Lib/test/test_tkinter/
0f60bef

Add Lib/test/test_tkinter/__init__.py
8ee5ffe
Remove Lib/test/test_tk.py.

matejc pushed a commit to matejc/nixpkgs that referenced this pull request Sep 24, 2025
python313Packages.tkinter: fix test selection for darwin, older python
a6ec45e
python/cpython#94070

tm-drtina pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 29, 2025
python313Packages.tkinter: fix test selection for darwin, older python
fa0cc8a
python/cpython#94070

Uh oh!

Uh oh!

Conversation

vstinner commented Jun 21, 2022• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

zware commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

zooba commented Jun 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Jun 21, 2022

Uh oh!

terryjreedy commented Jun 21, 2022

Uh oh!

terryjreedy commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Jun 21, 2022

Uh oh!

vstinner commented Jun 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Jun 21, 2022

Uh oh!

vstinner commented Jun 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vstinner commented Jun 21, 2022•
edited by bedevere-bot
Loading

vstinner commented Jun 21, 2022•
edited
Loading

vstinner commented Jun 21, 2022•
edited
Loading