Skip to content

gh-94393: Remove unneeded module state from _json - #94394

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:remove-unneeded-state-from-json
Jul 2, 2022
Merged

gh-94393: Remove unneeded module state from _json#94394
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:remove-unneeded-state-from-json

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Also simplify ref.counting by using modern C API for adding the type objects.

Comment threadModules/_json.c Outdated
@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

FYI, I'll merge this in a couple of days.

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm please go ahead.

@erlend-aasland
erlend-aasland merged commit 3a2e615 into python:mainJul 2, 2022
@erlend-aasland
erlend-aasland deleted the remove-unneeded-state-from-json branch July 2, 2022 06:24
@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unneeded module state from _json module

4 participants

@erlend-aasland@encukou@corona10@bedevere-bot