Uh oh!
There was an error while loading. Please reload this page.
gh-94512: Fix forced arg format in AC-processed overlapped - #94516
Merged
Conversation
7 tasks
arhadthedev
commented
Jul 2, 2022
MemberAuthor
|
arhadthedev
marked this pull request as draft
July 2, 2022 21:36
MemberAuthor
False alarm, underlying pointer processing already does this. |
arhadthedev
marked this pull request as ready for review
July 2, 2022 21:56
This reverts commit af8f603.
gvanrossum
commented
Jul 31, 2022
Member
Did this cause some GitHub warnings? E.g. at the end of https://github.com/python/cpython/pull/95253/files there are some warnings like |
MemberAuthor
@gvanrossum A two-step fix is ready:
|
zooba
commented
Aug 1, 2022
Member
Can we quick fix it by making AC generate casts for |
arhadthedev
commented
Aug 1, 2022
MemberAuthor
@zooba I agree with a quick fix here and now. Here it is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that this PR redefines a local hierarchy of converters by inserting a universal pointer converter as a common root.