Uh oh!
There was an error while loading. Please reload this page.
gh-92546: Move pprint benchmark into pyperformance - #94613
Merged
Conversation
This was referenced Jul 6, 2022
hauntsaninja
approved these changes
Jul 8, 2022
hauntsaninja
left a comment
Contributor
There was a problem hiding this comment.
Had a nit, but looks good!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
arhadthedev
commented
Jul 8, 2022
MemberAuthor
Restart tests because |
arhadthedev
commented
Jul 24, 2022
MemberAuthor
@ericsnowcurrently Could you look at this PR please? It removes the code fetched by python/pyperformance#222. |
ericsnowcurrently
approved these changes
Jul 25, 2022
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
LGTM, aside from one small change.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
commented
Jul 25, 2022
Contributor
Status check is done, and it's a success ✅ . |
ericsnowcurrently
commented
Jul 26, 2022
Member
Thanks for working on this, @arhadthedev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment).
Automerge-Triggered-By: GH:ericsnowcurrently