Skip to content

gh-94628: Add explicit parameter list to sqlite3.connect docs - #94629

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-doc-connect
Jul 7, 2022
Merged

gh-94628: Add explicit parameter list to sqlite3.connect docs#94629
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-doc-connect

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 6, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 6, 2022
@erlend-aaslanderlend-aasland linked an issue Jul 6, 2022 that may be closed by this pull request
Doc: Add explicit parameter list to sqlite3.connect #94628
Closed
@CAM-Gerlach

This comment was marked as resolved.

Sign in to view
CAM-Gerlach
CAM-Gerlach reviewed Jul 7, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; a few comments...

Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
@erlend-aasland

erlend-aasland commented Jul 7, 2022

Copy link
Copy Markdown
ContributorAuthor

FYI, if you want to actually add me as a co-author of the commit(s) that shows up in Git and GitHub, you can add [...]

Thanks, I already do that ;)

Thanks for reviewing!

@erlend-aasland
erlend-aasland merged commit 3eb2b96 into python:mainJul 7, 2022
@miss-islington

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3eb2b9634fdc6826a558fa5aa820dc6e69b7800e 3.11

@miss-islington

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3eb2b9634fdc6826a558fa5aa820dc6e69b7800e 3.10

@erlend-aasland
erlend-aasland deleted the sqlite-doc-connect branch July 7, 2022 07:10
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94645 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.11]pythongh-94628: Add explicit parameter list to sqlite3.connect…
b09efdd
… docs (pythonGH-94629)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 3eb2b96)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10]pythongh-94628: Add explicit parameter list to sqlite3.connect…
3934e9d
… docs (pythonGH-94629)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 3eb2b96)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2022
@bedevere-bot

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94646 is a backport of this pull request to the 3.10 branch.

@erlend-aaslanderlend-aasland mentioned this pull request Jul 7, 2022
Closed
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.11]gh-94628: Add explicit parameter list to sqlite3.connect docs (G…
3517c13
…H-94629) (#94645)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 3eb2b96)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10]gh-94628: Add explicit parameter list to sqlite3.connect docs (G…
663aa6e
…H-94629) (#94646)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 3eb2b96)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
sidney pushed a commit to sidney/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland@CAM-Gerlach@sidney
pythongh-94628: Add explicit parameter list to sqlite3.connect docs (p…
f9ff8d2
…ython#94629)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aaslanderlend-aasland mentioned this pull request Sep 27, 2022
Closed
erlend-aasland pushed a commit that referenced this pull request Sep 27, 2022
@jiajunjie
[3.10]gh-97567: Fixup cached_statements default value in sqlite3.con…
6a41d11
…nect docs (#97568)
This docs inconsistency was introduced by the 3.10 backport of gh-94629: gh-94646
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

@erlend-aaslanderlend-aasland

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc: Add explicit parameter list to sqlite3.connect

4 participants

@erlend-aasland@CAM-Gerlach@miss-islington@bedevere-bot