Skip to content

gh-94808: Add coverage for boolobject.c:bool_new - #94859

Merged
miss-islington merged 2 commits into
python:mainfrom
mdboom:coverage-boolobject
Jul 14, 2022
Merged

gh-94808: Add coverage for boolobject.c:bool_new#94859
miss-islington merged 2 commits into
python:mainfrom
mdboom:coverage-boolobject

Conversation

@mdboom

@mdboommdboom commented Jul 14, 2022•
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

bool_new had no coverage.

Automerge-Triggered-By: GH:brandtbucher

@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 14, 2022
@mdboommdboom mentioned this pull request Jul 14, 2022
Open
brandtbucher
brandtbucher requested changes Jul 14, 2022
View reviewed changes
Comment threadLib/test/test_bool.py Outdated
@bedevere-bot

bedevere-bot commented Jul 14, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mdboom@brandtbucher
Update Lib/test/test_bool.py
7d4c3a8
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@mdboom

mdboom commented Jul 14, 2022

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jul 14, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

@miss-islington

miss-islington commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit df4d53a into python:mainJul 14, 2022
@brandtbucherbrandtbucher added the needs backport to 3.11 only security fixes label Jul 15, 2022
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2022
@mdboom@miss-islington
pythongh-94808: Add coverage for boolobject.c:bool_new (pythonGH-94859)
d5ebce6
`bool_new` had no coverage.
Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit df4d53a)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

GH-94883 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
brandtbucher pushed a commit that referenced this pull request Jul 15, 2022
@miss-islington@mdboom
gh-94808: Add coverage for boolobject.c:bool_new (GH-94859) (GH-94883)
8dc4de3
`bool_new` had no coverage.
Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit df4d53a)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdboom@bedevere-bot@miss-islington@brandtbucher@kumaraditya303