Skip to content

gh-54781: Mention sqlite3 test relocation in What's New - #95059

Closed
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:mention-sqlite-test-move
Closed

gh-54781: Mention sqlite3 test relocation in What's New#95059
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:mention-sqlite-test-move

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 20, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aaslanderlend-aasland mentioned this pull request Jul 20, 2022
Closed
@erlend-aaslanderlend-aasland added the needs backport to 3.11 only security fixes label Jul 20, 2022
@erlend-aaslanderlend-aasland mentioned this pull request Jul 20, 2022
Merged
@erlend-aaslanderlend-aasland changed the title bpo-10572: Mention sqlite3 test relocation in What's Newgh-54781: Mention sqlite3 test relocation in What's NewJul 20, 2022
@zware

zware commented Jul 20, 2022

Copy link
Copy Markdown
Member

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.

@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.

Right, thanks for the historical context. If so, I believe it is better to close this PR.

@erlend-aaslanderlend-aasland added pending The issue will be closed if no feedback is provided DO-NOT-MERGE labels Jul 20, 2022
@terryjreedy

terryjreedy commented Jul 20, 2022

Copy link
Copy Markdown
Member

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.

@zware

zware commented Jul 20, 2022

Copy link
Copy Markdown
Member

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.

@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
ContributorAuthor

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.

"No sweat, I'll make him into a disciple." 🎨 🖌️

@erlend-aaslanderlend-aasland removed needs backport to 3.11 only security fixes pending The issue will be closed if no feedback is provided labels Jul 20, 2022
@erlend-aasland

erlend-aasland commented Jul 20, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'll create a new PR against 3.11 for the NEWS entry, then. UPDATE:

@erlend-aasland
erlend-aasland deleted the mention-sqlite-test-move branch July 20, 2022 18:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees

No one assigned

Labels

DO-NOT-MERGEdocsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@zware@terryjreedy@bedevere-bot