Uh oh!
There was an error while loading. Please reload this page.
[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail… - #95099
Closed
graingert wants to merge 2 commits into
Closed
[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…#95099graingert wants to merge 2 commits into
graingert wants to merge 2 commits into
Conversation
…s_fails_with_inactive_watcher (pythonGH-95009) The test was never run, because it was missing the TestCase class. The test failed because the wrong attribute was patched. (cherry picked from commit 834bd5d) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
graingertforce-pushed
the
backport-834bd5d-3.10
branch
from
July 21, 2022 17:59
9035b28 to
4b59f79Compare
Comment on lines
864
to
868
There was a problem hiding this comment.
Why not just use self.loop.run_until_complete() as in other tests?
ContributorAuthor
There was a problem hiding this comment.
the GenericWatcherTests don't have a self.loop, and SubprocessWatcherMixin (which sets self.loop) calls get_event_loop_policy().attach_loop and this test case is testing what happens when attach_loop isn't called
There was a problem hiding this comment.
Many classes set self.loop. For this test you can inherit from test_utils.TestCase and add
defsetUp(self):
super().setUp()
self.loop=asyncio.new_event_loop()
self.set_event_loop(self.loop)graingertforce-pushed
the
backport-834bd5d-3.10
branch
from
July 21, 2022 18:36
4b59f79 to
ca48762Comparegraingert
commented
Jul 23, 2022
ContributorAuthor
I think I'll try to hurdle this hurdle when backporting #94184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s_with_inactive_watcher (GH-95009)
The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)
Co-authored-by: Thomas Grainger tagrain@gmail.com
GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcheris not run #95010