Uh oh!
There was an error while loading. Please reload this page.
[3.11] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) - #95261
Conversation
…H-95058) * syslog_get_argv() swallows exceptions, but not in all cases. * if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally in the previous call to openlog() points to the freed memory. * PySys_Audit() can crash if ident is NULL. * There may be a race condition with syslog.syslog(), because the global reference to ident is decrefed before setting the new value. * Possible use of freed memory if syslog.openlog() is called while the GIL is released in syslog.syslog(). (cherry picked from commit 68c555a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
commented
Jul 26, 2022
Status check is done, and it's a success ✅ . |
2 similar comments
miss-islington
commented
Jul 26, 2022
Status check is done, and it's a success ✅ . |
miss-islington
commented
Jul 26, 2022
Status check is done, and it's a success ✅ . |
miss-islington
commented
Jul 26, 2022
Sorry, I can't merge this PR. Reason: |
miss-islington
commented
Jul 26, 2022
Status check is done, and it's a success ✅ . |
miss-islington
commented
Jul 26, 2022
Sorry, I can't merge this PR. Reason: |
miss-islington
commented
Jul 26, 2022
Status check is done, and it's a success ✅ . |
miss-islington
commented
Jul 26, 2022
Sorry, I can't merge this PR. Reason: |
global reference to ident. Now the C string saved internally in the previous
call to openlog() points to the freed memory.
reference to ident is decrefed before setting the new value.
the GIL is released in syslog.syslog().
(cherry picked from commit 68c555a)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com