Skip to content

gh-95273: Normalise sqlite3 reference wording - #95274

Merged
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-reference/be-consistent
Jul 27, 2022
Merged

gh-95273: Normalise sqlite3 reference wording#95274
erlend-aasland merged 10 commits into
python:mainfrom
erlend-aasland:sqlite-reference/be-consistent

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 26, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland
erlend-aasland commented Jul 26, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
erlend-aasland
erlend-aasland commented Jul 26, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst
@erlend-aaslanderlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 26, 2022
CAM-Gerlach
CAM-Gerlach reviewed Jul 27, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments

Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
AlexWaygood
AlexWaygood reviewed Jul 27, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few small points

Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
AlexWaygood
AlexWaygood reviewed Jul 27, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
Erlend Egeberg Aasland@AlexWaygood
Missed one spot
4cf5af4
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Jul 27, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@erlend-aasland

erlend-aasland commented Jul 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Great, thanks again, both of you!

@erlend-aasland
erlend-aasland merged commit 2361908 into python:mainJul 27, 2022
@miss-islington

miss-islington commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the sqlite-reference/be-consistent branch July 27, 2022 13:24
@miss-islington

miss-islington commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2361908a9d5553102f2b2294af44852a76d2ab03 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
Erlend Egeberg Aasland@miss-islington
pythongh-95273: Normalise sqlite3 reference wording (pythonGH-95274)
540833f
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 2361908)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022
@bedevere-bot

bedevere-bot commented Jul 27, 2022

Copy link
Copy Markdown

GH-95329 is a backport of this pull request to the 3.11 branch.

@bedevere-bot

bedevere-bot commented Jul 27, 2022

Copy link
Copy Markdown

GH-95330 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2022
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jul 27, 2022
Erlend Egeberg Aasland@erlend-aasland
[3.10]pythongh-95273: Normalise sqlite3 reference wording (pythonGH-…
056afa8
…95274)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 2361908)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
miss-islington added a commit that referenced this pull request Jul 27, 2022
@miss-islingtonErlend Egeberg Aasland
gh-95273: Normalise sqlite3 reference wording (GH-95274)
e14c4d5
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 2361908)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland pushed a commit that referenced this pull request Jul 27, 2022
Erlend Egeberg Aasland
[3.10]gh-95273: Normalise sqlite3 reference wording (GH-95274) (#95330)
2ef7a72
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit 2361908)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

@erlend-aaslanderlend-aasland

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

5 participants

@erlend-aasland@miss-islington@bedevere-bot@CAM-Gerlach@AlexWaygood