Uh oh!
There was an error while loading. Please reload this page.
[3.11] GH-92678: Fix tp_dictoffset inheritance. Backport of GH-95596 - #95604
Merged
Conversation
markshannon
commented
Aug 3, 2022
MemberAuthor
Bah, Modules/_testcapi/heaptype.c doesn't exist in 3.11. I'll need to fix it up manually. |
* Add test for inheriting explicit __dict__ and weakref. * Restore 3.10 behavior for multiple inheritance of C extension classes that store their dictionary at the end of the struct.
markshannonforce-pushed
the
backport-95596
branch
from
August 3, 2022 18:35
f8c4d28 to
53093f3Comparebedevere-bot
commented
Aug 3, 2022
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 53093f3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
pablogsal
approved these changes
Aug 4, 2022
gvanrossum
commented
Aug 4, 2022
Member
What about the Windows warnings (see the Files section of this PR)? |
Member
Yeah, those are legitimate errors, it should return |
pablogsal
commented
Aug 4, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #95596