Uh oh!
There was an error while loading. Please reload this page.
gh-94808: Add coverage for bytesarray_setitem - #95802
Conversation
5f24775 to
e717c5cComparee717c5c to
1c2a344Compare
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good. Any reason you didn't mark this for backporting to 3.10?
mdboom
commented
Oct 10, 2022
No real reason not to -- for all these other coverage improvements linked to #94808, we've just been backporting to 3.11. |
miss-islington
commented
Oct 10, 2022
Thanks @mdboom for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
commented
Oct 10, 2022
Sorry, @mdboom and @JelleZijlstra, I could not cleanly backport this to |
miss-islington
commented
Oct 10, 2022
Sorry @mdboom and @JelleZijlstra, I had trouble checking out the |
JelleZijlstra
commented
Oct 10, 2022
Thanks! I think it's good to backport new tests to the bugfix branches so we can be more confident in any future bugfixes. But testing on 3.11 is definitely more important. Would you mind doing the manual backports? Feel free to skip 3.10 if you don't think it's worth it. |
When both are provided,
tp_ass_subscripttakes precedence overtp_ass_item. Sincebytesarrayprovides both, the existingtest_setitemtests forbytesarraywere not testingbytesarray_setitem, butbytesarray_ass_subscript. This is mostly fine, since Python code has to jump through some hoops to even call it, but a third-party library usingPySequence_SetItemcould potentially run into this uncovered case.