gh-90928: Improve static initialization of keywords tuple in AC by erlend-aasland · Pull Request #95907 · python/cpython

erlend-aasland · 2022-08-11T21:38:14Z

Calculate num_keywords during template generation instead of leaving it to the preprocessor. This makes for much smaller and easier to read (FWIW) AC output.

See discussion in #95860 (comment)

Issue: Statically Initialize PyArg_Parser in clinic.py #90928

Deduce num_keywords from f.parameters

ericsnowcurrently

Thanks for working on this! Mostly LGTM.

Also, can you drop "num_keywords" from template_dict now?

bedevere-bot · 2022-08-11T23:16:40Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

erlend-aasland · 2022-08-11T23:20:29Z

Also, can you drop "num_keywords" from template_dict now?

It is already dropped :)

erlend-aasland · 2022-08-11T23:33:36Z

I have made the requested changes; please review again.

bedevere-bot · 2022-08-11T23:33:40Z

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

ericsnowcurrently

LGTM

I'll leave it up to you about the two comments I left.

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

erlend-aasland · 2022-08-12T17:29:36Z

Thanks for reviewing; highly appreciated. I'll make a quick adjustment before landing.

- inline len(keywords) - use NUM_KEYWORDS constant for improved readability in generated code

erlend-aasland · 2022-08-12T17:38:33Z

I'm done with the last round of adjustments. I ended up adding both of your last suggestions. Thanks again.

erlend-aasland · 2022-08-12T17:39:39Z

FYI, I'll wait with merging until Kumar has finished his review.

kumaraditya303

LGTM, thanks!

erlend-aasland · 2022-08-13T10:09:29Z

Thanks for the reviews!

erlend-aasland added 2 commits August 11, 2022 23:36

Proof of concept
cee430f
Deduce num_keywords from f.parameters

Calculate num_keywords during template generation
bda509a

bedevere-bot added the awaiting core review label Aug 11, 2022

erlend-aasland mentioned this pull request Aug 11, 2022
gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code #95860
Merged

erlend-aasland requested a review from ericsnowcurrently August 11, 2022 21:43

erlend-aasland added the skip news label Aug 11, 2022

Regen clinic.test
793c5aa

erlend-aasland marked this pull request as ready for review August 11, 2022 22:51

erlend-aasland requested review from a team, 1st1, abalkin, asvetlov, berkerpeksag, ethanfurman, pganssle, rhettinger and tiran as code owners August 11, 2022 22:51

erlend-aasland removed request for a team, 1st1, abalkin, asvetlov, berkerpeksag, ethanfurman, pganssle, rhettinger and tiran August 11, 2022 22:51

ericsnowcurrently requested changes Aug 11, 2022
View reviewed changes

Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated

bedevere-bot added awaiting changes and removed awaiting core review labels Aug 11, 2022

Address review
568a49c

bedevere-bot added awaiting change review and removed awaiting changes labels Aug 11, 2022

bedevere-bot requested a review from ericsnowcurrently August 11, 2022 23:33

kumaraditya303 self-requested a review August 12, 2022 17:09

ericsnowcurrently approved these changes Aug 12, 2022
View reviewed changes

Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated

bedevere-bot added awaiting merge and removed awaiting change review labels Aug 12, 2022

Update Tools/clinic/clinic.py
f1d533c
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

erlend-aasland commented Aug 12, 2022
View reviewed changes

Comment threadTools/clinic/clinic.py Outdated

Address last round of reviews
8915c05
- inline len(keywords) - use NUM_KEYWORDS constant for improved readability in generated code

kumaraditya303 approved these changes Aug 13, 2022
View reviewed changes

erlend-aasland merged commit f07adf8 into python:mainAug 13, 2022

bedevere-bot removed the awaiting merge label Aug 13, 2022

erlend-aasland deleted the improve-gh-95860 branch August 13, 2022 10:10

erlend-aasland mentioned this pull request Aug 16, 2023
gh-107704: Argument Clinic: add support for deprecating keyword use of parameters #107984
Merged

Uh oh!

Uh oh!

Conversation

erlend-aasland commented Aug 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Aug 11, 2022

Uh oh!

erlend-aasland commented Aug 11, 2022

Uh oh!

erlend-aasland commented Aug 11, 2022

Uh oh!

bedevere-bot commented Aug 11, 2022

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Aug 12, 2022

Uh oh!

erlend-aasland commented Aug 12, 2022

Uh oh!

erlend-aasland commented Aug 12, 2022

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Aug 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Aug 11, 2022•
edited
Loading