Skip to content

gh-94808: Coverage: Test uppercase string literal prefixes - #95925

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
mdboom:coverage-upper-case-literal-prefixes
Sep 24, 2022
Merged

gh-94808: Coverage: Test uppercase string literal prefixes#95925
serhiy-storchaka merged 3 commits into
python:mainfrom
mdboom:coverage-upper-case-literal-prefixes

Conversation

@mdboom

@mdboommdboom commented Aug 12, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 12, 2022
@mdboommdboom mentioned this pull request Aug 12, 2022
Open
iritkatriel
iritkatriel reviewed Sep 7, 2022
View reviewed changes
Comment threadLib/test/test_string_literals.py Outdated
self.assertEqual(eval(r""" R'\x01' """), '\\x01')
self.assertEqual(eval(r""" BR'\x01' """), b'\\' + b'x01')
self.assertEqual(eval(""" F'{1+1}' """), '2')
self.assertEqual(eval(""" U'\U0001d120' """), '\U0001d120')

@iritkatrieliritkatrielSep 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the lowercase versions are covered by other tests (right?)

Would it be simpler here to just assert in each case that the lowercase and upper case prefixes generate the same thing? For instance, self.assertEqual(eval(""" F'{1+1}' """), eval(""" f'{1+1}' """)).

@mdboommdboomSep 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Updated.

@iritkatriel

iritkatriel commented Sep 7, 2022

Copy link
Copy Markdown
Member

IIUC this is covering the uppercase cases here: http://droettboom.com/cpython-coverage/llvm-coverage/coverage/home/mdboom/Work/builds/cpython/Parser/string_parser.c.html#L183

iritkatriel
iritkatriel reviewed Sep 22, 2022
View reviewed changes
Comment threadLib/test/test_string_literals.py Outdated
self.assertEqual(eval(r""" R'\x01' """), r'\x01')
self.assertEqual(eval(r""" BR'\x01' """), br'\x01')
self.assertEqual(eval(""" F'{1+1}' """), f'{1+1}')
self.assertEqual(eval(""" U'\U0001d120' """), u'\U0001d120')

@iritkatrieliritkatrielSep 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually do we need the eval() calls?

serhiy-storchaka
serhiy-storchaka reviewed Sep 24, 2022
View reviewed changes
Comment threadLib/test/test_string_literals.py Outdated
@serhiy-storchaka
serhiy-storchaka merged commit f00383e into python:mainSep 24, 2022
@miss-islington

miss-islington commented Sep 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 24, 2022

Copy link
Copy Markdown

GH-97518 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2022
@mdboom@miss-islington
pythongh-94808: Coverage: Test uppercase string literal prefixes (pyt…
cda3a30
…honGH-95925)
(cherry picked from commit f00383e)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
@miss-islington@mdboom
gh-94808: Coverage: Test uppercase string literal prefixes (GH-95925)
6daff06
(cherry picked from commit f00383e)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.10 only security fixes label Sep 25, 2022
@miss-islington

miss-islington commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Sep 25, 2022
@bedevere-bot

bedevere-bot commented Sep 25, 2022

Copy link
Copy Markdown

GH-97537 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2022
@mdboom@miss-islington
pythongh-94808: Coverage: Test uppercase string literal prefixes (pyt…
567fea8
…honGH-95925)
(cherry picked from commit f00383e)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
miss-islington added a commit that referenced this pull request Sep 25, 2022
@miss-islington@mdboom
gh-94808: Coverage: Test uppercase string literal prefixes (GH-95925)
00713a8
(cherry picked from commit f00383e)
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@mdboom
mdboom deleted the coverage-upper-case-literal-prefixes branch December 22, 2022 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdboom@iritkatriel@miss-islington@bedevere-bot@serhiy-storchaka