Skip to content

gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) - #96034

Merged
tiran merged 1 commit into
python:mainfrom
tiran:gh-96005-bsd
Aug 17, 2022
Merged

gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034)#96034
tiran merged 1 commit into
python:mainfrom
tiran:gh-96005-bsd

Conversation

@tiran

@tirantiran commented Aug 16, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tiran
tiran requested a review from pablogsalAugust 16, 2022 20:04
@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 16, 2022
@tiran

tiran commented Aug 16, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Problem: FreeBSD has ENOTCAPABLE, too. This means that the original changeset maps ENOTCAPABLE to PermissionError on FreeBSD as well. We never wrapped the errno, so it should be ok.

 93	ENOTCAPABLE Capabilities insufficient.	An operation on	a capability
file descriptor requires greater privilege	than the capability
allows.

https://www.freebsd.org/cgi/man.cgi?query=errno&sektion=2&manpath=freebsd-release-ports

@tirantiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 16, 2022
@bedevere-bot

bedevere-bot commented Aug 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 0e36363 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@tirantiran changed the title gh-96005: FreeBSD has ENOTCAPABLE, toogh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034)Aug 17, 2022
@tiran
tiran merged commit da0aa51 into python:mainAug 17, 2022
@tiran
tiran deleted the gh-96005-bsd branch August 17, 2022 05:24
@tirantiran added the needs backport to 3.11 only security fixes label Aug 17, 2022
@miss-islington

miss-islington commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da0aa518bf5e6ac9de444a405c40649cfb0245eb 3.11

@tirantiran removed the needs backport to 3.11 only security fixes label Aug 17, 2022
tiran added a commit to tiran/cpython that referenced this pull request Aug 17, 2022
@tiran
pythongh-96005: FreeBSD has ENOTCAPABLE, too (pythonGH-96034)
5f4adff
tiran added a commit that referenced this pull request Sep 13, 2022
@tiran
[3.11]gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) (GH-96034
bc337a7
) (GH-96038)
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
files `pybuilddir.txt` and `pyenv.cfg`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsal
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees

@tirantiran

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran@bedevere-bot@miss-islington