Skip to content

gh-96397: Document that attributes need not be identifiers - #96454

Merged
gvanrossum merged 2 commits into
python:mainfrom
jeff5:doc-accept-nonid-attrs
Sep 29, 2022
Merged

gh-96397: Document that attributes need not be identifiers#96454
gvanrossum merged 2 commits into
python:mainfrom
jeff5:doc-accept-nonid-attrs

Conversation

@jeff5

@jeff5jeff5 commented Aug 31, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Companion to #96393, and stemming from points made in the discussions at https://discuss.python.org/t/supporting-or-not-invalid-identifiers-in-kwargs/17147/26 and #96397, this proposes extending how we define "attribute" to match the behaviour of implementations and some current user practice.

Needs SC discussion, I believe.

@jeff5
Docs: attributes need not be identifiers
57522c9
Clarify that the name of an attribute need not be a valid Python identifier, in particular through setarr(), noting that this precludes use of the dot notation to access them.
@bedevere-botbedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 31, 2022
@jeff5jeff5 mentioned this pull request Aug 31, 2022
Closed
ChrisBarker-NOAA
ChrisBarker-NOAA reviewed Sep 1, 2022
View reviewed changes

@ChrisBarker-NOAAChrisBarker-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- I've suggested a bit more verbose text, but not critical.

Comment threadDoc/library/functions.rst
Comment threadDoc/library/functions.rst
Comment threadDoc/library/functions.rst
This was referenced Sep 13, 2022
Merged
Closed
@jeff5

jeff5 commented Sep 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Could this be merged, or have I more to do?

gvanrossum
gvanrossum approved these changes Sep 29, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional suggestion.

Comment threadDoc/glossary.rst Outdated
@gvanrossum@CAM-Gerlach
Mention getattr in definition of attribute
6deda04
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@gvanrossum
gvanrossum merged commit 9a11ed8 into python:mainSep 29, 2022
@gvanrossumgvanrossum added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 29, 2022
@miss-islington

miss-islington commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @jeff5 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @jeff5 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 29, 2022

Copy link
Copy Markdown

GH-97658 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 29, 2022
@bedevere-bot

bedevere-bot commented Sep 29, 2022

Copy link
Copy Markdown

GH-97659 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2022
@jeff5@miss-islington
pythongh-96397: Document that attributes need not be identifiers (pyt…
6f35088
…honGH-96454)
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)
Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2022
@jeff5@miss-islington
pythongh-96397: Document that attributes need not be identifiers (pyt…
9cd0c6d
…honGH-96454)
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)
Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull request Sep 29, 2022
@miss-islington@jeff5
gh-96397: Document that attributes need not be identifiers (GH-96454)
27891e0
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)
Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
miss-islington added a commit that referenced this pull request Sep 29, 2022
@miss-islington@jeff5
gh-96397: Document that attributes need not be identifiers (GH-96454)
0688f11
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)
Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@jeff5@CAM-Gerlach@serhiy-storchaka
pythongh-96397: Document that attributes need not be identifiers (pyt…
679cf96
…hon#96454)
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@AlexWaygoodAlexWaygood mentioned this pull request Oct 11, 2022
Closed
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington@jeff5@pablogsal
gh-96397: Document that attributes need not be identifiers (GH-96454)
f20ad5e
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 9a11ed8)
Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments
@merwokmerwokmerwok approved these changes
@gvanrossumgvanrossumgvanrossum approved these changes
+1 more reviewer
@ChrisBarker-NOAAChrisBarker-NOAAChrisBarker-NOAA left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jeff5@miss-islington@bedevere-bot@merwok@ChrisBarker-NOAA@gvanrossum@CAM-Gerlach