Skip to content

gh-96168: Improve sqlite3 dict_factory example - #96457

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-docs-dict-factory
Sep 1, 2022
Merged

gh-96168: Improve sqlite3 dict_factory example#96457
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-docs-dict-factory

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Aug 31, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • use dict comprehension
  • use doctest iso. testcode, for visualising the
    effect of the row factory
  • SELECT with multiple columns, so the effect of
    the row factory becomes clearer

@erlend-aasland
pythongh-96168: Improve sqlite3 dict_factory example
430bb2a
- use dict comprehension
- use doctest iso. testcode, for visualising the
effect of the row factory
- SELECT with multiple columns, so the effect of
the row factory becomes clearer
@erlend-aaslanderlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Aug 31, 2022
@bedevere-botbedevere-bot added docs Documentation in the Doc dir skip news labels Aug 31, 2022
ezio-melotti
ezio-melotti reviewed Aug 31, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
ezio-melotti
ezio-melotti approved these changes Aug 31, 2022
View reviewed changes
Comment threadDoc/library/sqlite3.rst Outdated
CAM-Gerlach
CAM-Gerlach reviewed Sep 1, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments, otherwise LGTM 👍 It looks a lot clearer to me than before, as well as more testable, concise and following more modern coding practices.

Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst
Erlend E. Aasland@CAM-Gerlach
Address review: fix SQL style
c4c9656
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland

erlend-aasland commented Sep 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews, CAM & Ezio!

@erlend-aasland
erlend-aasland merged commit 91f40f3 into python:mainSep 1, 2022
@miss-islington

miss-islington commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the sqlite-docs-dict-factory branch September 1, 2022 21:48
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Sep 1, 2022
@bedevere-bot

bedevere-bot commented Sep 1, 2022

Copy link
Copy Markdown

GH-96494 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
Erlend E. Aasland@miss-islington
pythongh-96168: Improve sqlite3 dict_factory example (pythonGH-96457)
cdb3bd1
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 91f40f3)
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Sep 1, 2022

Copy link
Copy Markdown

GH-96495 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
Erlend E. Aasland@miss-islington
pythongh-96168: Improve sqlite3 dict_factory example (pythonGH-96457)
1dfce7a
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 91f40f3)
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Sep 1, 2022
miss-islington added a commit that referenced this pull request Sep 1, 2022
@miss-islingtonErlend E. Aasland
gh-96168: Improve sqlite3 dict_factory example (GH-96457)
fca8e94
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 91f40f3)
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Sep 1, 2022
@miss-islingtonErlend E. Aasland
gh-96168: Improve sqlite3 dict_factory example (GH-96457)
bbcb03e
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 91f40f3)
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland mentioned this pull request Nov 25, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments
@ezio-melottiezio-melottiezio-melotti approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@miss-islington@bedevere-bot@CAM-Gerlach@ezio-melotti