Uh oh!
There was an error while loading. Please reload this page.
gh-97588: Failing tests to demonstrate the issue - #97589
gh-97588: Failing tests to demonstrate the issue#97589matthiasgoergens wants to merge 18 commits into
Conversation
matthiasgoergens
commented
Sep 30, 2022
@mdickinson I marked the tests as failing, so we cant potentially get them into |
nanjekyejoannah
left a comment
There was a problem hiding this comment.
Shouldn't we be patching a fix instead? Unless we are accepting this as desired behaviour.
matthiasgoergens
commented
Oct 6, 2022
@nanjekyejoannah See #97702 for the fix. |
matthiasgoergens
commented
Oct 8, 2022
@nanjekyejoannah I'm not completely confident in the fix, yet. But I am confident that these test cases are good. Not sure we have a general policy against contributing failing test cases? |
nanjekyejoannah
left a comment
There was a problem hiding this comment.
The tests test the failing caes. But with the fix, these tests will change i.e not failing, I would prefer reviewing a PR with a fix and updated tests, since there is a fix. What do you think?
matthiasgoergens
commented
Oct 11, 2022
@nanjekyejoannah Feel free to review #97702 |
2acd7a9 to
be065d5Compareencukou
commented
Aug 26, 2024
These were merged with #97702. Thank you! |
The tests are expected to fail, and are marked as such.